splineoverlap.c:2146 always evaluates to true

[davelab6]

Email today:

I just ran the static analysis checker "cppcheck" over
the source code of fontforge.

Amongst many other things, cppcheck said

[charinfo.c:3618]: (warning) Logical disjunction always evaluates to true: uni>= 912 || uni < 943.

[splineoverlap.c:2146]: (warning) Logical conjunction always evaluates to false: nwinding <= -2 && nwinding>= 2.

In both cases, suggest code rework.

Regards

David Binderman

[ahyangyi]

I guess the fix might be as simple as changing "||" to "&&" and vice versa. However, we need someone who can understand these magic things before making the change.

[JoesCat]

Used during Element->Overlap->Intersect.

[JoesCat]

See 9d05abd