Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTP/HTTPS proxies #249

Closed
ronaldtse opened this issue Jul 15, 2021 · 4 comments
Closed

Support HTTP/HTTPS proxies #249

ronaldtse opened this issue Jul 15, 2021 · 4 comments
Assignees
@alexeymorozov @CAMOBAP
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link
Contributor

In some organizations the corporate firewall blocks requests and requires usage of a corporate proxy.

Fontist needs to support the HTTP_PROXY and HTTPS_PROXY environment variables so that it can support these.

Required in: metanorma/metanorma#202 (comment)
@ronaldtse ronaldtse added the enhancement New feature or request label Jul 15, 2021
@CAMOBAP CAMOBAP assigned CAMOBAP and unassigned alexeymorozov Jul 15, 2021
@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 24, 2021

@ronaldtse no extra work need because HTTP_PROXY supports out-of-the-box. Also we decided to leave it up-to user how to configure git to work with proxy

Also to be on the same page:

  1. do we need to support it for case if fontist called as standalone command?
  2. do we need to support SOCKS proxy if fontist called as standalone command?

I'm asking because if fontist called as part of metanorma it works

@ronaldtse
Copy link
Contributor Author

  1. do we need to support it for case if fontist called as standalone command?
  2. do we need to support SOCKS proxy if fontist called as standalone command?

Yes.

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 25, 2021

@ronaldtse thanks for answers I will proceed

CAMOBAP added a commit that referenced this issue Jul 25, 2021
@CAMOBAP
#249 add SOCKS support + documentation to README
64c7c83
@CAMOBAP CAMOBAP mentioned this issue Jul 25, 2021
Merged
alexeymorozov pushed a commit that referenced this issue Jul 27, 2021
@CAMOBAP @alexeymorozov
#249 add SOCKS support + documentation to README
69f9335
@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 27, 2021

Merged

@CAMOBAP CAMOBAP closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeymorozov alexeymorozov

@CAMOBAP CAMOBAP

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronaldtse @alexeymorozov @CAMOBAP