Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): migrate to css modules and react 18 #854

Merged
merged 31 commits into from
Oct 1, 2023
Merged

Conversation

ayuhito
Copy link
Member

@ayuhito ayuhito commented Sep 28, 2023

Mantine V7 has dropped Emotion in favour of CSS modules which is a far more performant and cleaner solution to use. Our biggest blocker for updating to React 18 was all the bugs associated with CSS-in-JS, so this change lets us use all the streaming goodies included in React 18 in future updates.

The migration to CSS modules should also include minor improvements to accessibility and design from our end (e.g. a completely rewritten combobox component).

Closes #768 (which was a hydration bug).

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

⚠️ No Changeset found

Latest commit: ca20aa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ayuhito
Copy link
Member Author

ayuhito commented Oct 1, 2023

Not sure why staging won't deploy from GH Actions whilst local deploy using the remote builder does pass. There shouldn't be any mixed context too considering the strict dockerignore. For now, I'll merge since prod is already running this branch.

@ayuhito ayuhito merged commit ad624f9 into main Oct 1, 2023
1 of 4 checks passed
@ayuhito ayuhito deleted the website/mantine-v7 branch October 1, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font-category filter's checkboxes don't have visual feedback nor work as checkboxes
1 participant