Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webapp: we need a loading spinner #1131

Closed
felipesanches opened this issue Oct 26, 2016 · 2 comments
Closed

webapp: we need a loading spinner #1131

felipesanches opened this issue Oct 26, 2016 · 2 comments
Assignees
@felipesanches
Labels
P2 Important
Milestone
0.2.0 Binary Chec...

Comments

@felipesanches
Copy link
Collaborator

Expected behaviour

Display a "waiting for check results ..." with a spinner image so that the user knows something is going on.

Observed behaviour

Webapp feels frozen while waiting for server-side fontbakery run, due to the lack of a visual indicator of the ongoing activity.
@felipesanches felipesanches self-assigned this Oct 26, 2016
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 26, 2016
@felipesanches
animated version of the FontBakery logo using SVG SMIL
de8bc72 
animation attributes.
To be used as "loading spinner" in the webapp UI.
(issues fonttools#1131 & fonttools#1121)
@felipesanches
Copy link
Collaborator Author

FontBakery logo animated with SVG SMIL attributes to be used as a "spinner" on the webapp while waiting for the server-side check results:

https://github.com/felipesanches/fontbakery/blob/de8bc725ee8b8ed316361d2504b6b652edbccde1/data/animated_logo.svg

Isn't that cool ? :-D

@felipesanches felipesanches added this to the 0.2.0 milestone Oct 27, 2016
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 27, 2016
@felipesanches
animated version of the FontBakery logo using SVG SMIL
fc22634 
animation attributes.
To be used as "loading spinner" in the webapp UI.
(issues fonttools#1131 & fonttools#1121)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 27, 2016
@felipesanches
display a loading spinner overlay while fontbakery runs...
83d51a9 
...server-side.
(issues fonttools#1121 & fonttools#1131)
@felipesanches
Copy link
Collaborator Author

implemented on branch issue_1121 will be merged with the rest of the webapp code tracked by issue #1121

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 27, 2016
@felipesanches
animated version of the FontBakery logo using SVG SMIL
ca5d421 
animation attributes.
To be used as "loading spinner" in the webapp UI.
(issues fonttools#1131 & fonttools#1121)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Oct 27, 2016
@felipesanches
display a loading spinner overlay while fontbakery runs...
af882b6 
...server-side.
(issues fonttools#1121 & fonttools#1131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
P2 Important
Projects
None yet
Milestone
0.2.0 Binary Checks Are Reliable
Development

No branches or pull requests
1 participant
@felipesanches