Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine Vision: Do all font styles have the same visible height at all point sizes? #120

Open
davelab6 opened this issue Aug 7, 2013 · 14 comments
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id

Comments

@davelab6
Copy link
Contributor

davelab6 commented Aug 7, 2013

Following #246 ...

Write a machine vision test that ensures all font styles have the same visible height at all point sizes.

Adobe's Source Sans Pro in earlier versions has a bug that reproduces this, adobe-fonts/source-sans#25

@ghost ghost assigned davelab6 Aug 7, 2013
@davelab6 davelab6 removed their assignment Mar 6, 2014
@davelab6 davelab6 modified the milestones: 2.0, 2014-Q2 Week 11 May 30, 2014
@davelab6 davelab6 changed the title Do all font styles have the same visible height at all point sizes? Machine Vision: Do all font styles have the same visible height at all point sizes? May 30, 2014
@davelab6 davelab6 assigned vitalyvolkov and unassigned vitalyvolkov Jun 3, 2014
@davelab6 davelab6 modified the milestones: 2014-Q4 Week 35, 2.0 Nov 11, 2014
@davelab6 davelab6 modified the milestones: 2014-Q4 Week 35, 2.0 Nov 19, 2014
@davelab6 davelab6 modified the milestones: MISC, 2.0.0 Nov 7, 2017
@mattez
Copy link

mattez commented Nov 29, 2017

Issue is back. It is at least issue of WOFF2.

I made basic test of Font Size vs Font Weight on CodePen.
Screen shot of this test is attached.

Font source: Google Fonts.
Browsers:
Google Chrome last version - use WOFF2
Old Safari 8.0.8 - use [TTF]

source-sans-pro-issue-01
source-sans-pro-issue-02

@felipesanches
Copy link
Collaborator

Is that an outline geometry issue or is it related to hinting or other aspects of rendering ? I guess it's hinting, right? Can you clarify the problem description, please?

@felipesanches
Copy link
Collaborator

sounds like a task for @m4rc1e 's browserstack-based tool

@mattez
Copy link

mattez commented Nov 29, 2017

It is related to this: adobe-fonts/source-sans#25

I don't know if this issue is it related to hinting or other aspects of rendering.
I'm only web developer, who have to use this font, and find it has optically different sizes across its weights even if numeric pixel size is the same.

I want only point out, that visual tests mentioned in this thread are really desirable.

@miguelsousa
Copy link
Contributor

@felipesanches TrueType hinting

@mattez
Copy link

mattez commented Nov 29, 2017

@felipesanches you mean @m4rc1e 's https://github.com/m4rc1e/pybrowserstack-screenshots right?

@miguelsousa from my test it looks that TrueType is OK. For sure there is a problem with WOFF2 (based on OpenType).

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 29, 2017

@mattez This one https://github.com/m4rc1e/diffbrowsers, still beta and still awaiting review, googlefonts/diffbrowsers#1

You'll need a paid for Browserstack account to use it.

@mattez
Copy link

mattez commented Nov 29, 2017

Difference is so obvious arount size 28px ...
We you this combination on our webpage. Extra Light and Black.
image

Test i your self with my prototype tester on codepen in your browser.
You can set (in JavaScript top part):

  • tested string,
  • font weights,
  • font sizes (min/max)

@felipesanches
Copy link
Collaborator

@m4rc1e Am I correct that we plan to integrate your tool as a FontBakery automated test at some point in the near future? If so, then I think we might re-phrase the title of this issue here.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 29, 2017

@felipesanches The tool isn't fast, it really only needs to be run on prs for google/fonts. We should include it but use an optional flag to run it. Something like

Speaking of which, here's one I made earlier

@miguelsousa
Copy link
Contributor

@mattez if this issue only happens with otf-based fonts, there's nothing to fix in them; they already have the same family alignment zones (FamilyBlues & FamilyOtherBlues). Getting the different weights to lineup the way you want may require changes to the rasterizer.

@davelab6
Copy link
Contributor Author

@mattez also, you compare "WOFF2" vs "TTF" but WOFF and WOFF2 are just wrappers around other file types, like ZIP. What is inside the WOFF2 - also a TTF?

Comparing OTF vs TTF can be useful

@mattez
Copy link

mattez commented Nov 30, 2017

I start with test in my most favorite browsers. I'm going to tested on other Platforms and Browsers combinations.
system: Ubuntu 16.06 LTS
browsers:
Google Chrome 63 (64-bit)
Firefox 57 (64-bit)
fonts: Last released fonts downloaded yesterday form this repo via bower. I used no WOFF or WOFF2 files. I used OTF or TTF.

Here are results
selection_084
selection_085
selection_086
selection_087

@mattez
Copy link

mattez commented Nov 30, 2017

Here are results from Windows 10. I its looking really fine and OK. So it is probably not problem of font but some problem on operating system or what.

system: Windows 10
browsers:
last Google Chrome
last Firefox
last Edge
fonts: Last released fonts downloaded yesterday form this repo via bower. I used no WOFF or WOFF2 files. I used OTF or TTF.

fontsize-test-chrome-01
fontsize-test-chrome-02
fontsize-test-edge-01
fontsize-test-edge-02
fontsize-test-firefox-01
fontsize-test-firefox-02

@felipesanches felipesanches modified the milestones: 1.0.0 and beyond - Advanced/fancy stuff, Left-over from 2013 Dec 14, 2018
@felipesanches felipesanches added New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id and removed testing labels Mar 6, 2020
@felipesanches felipesanches modified the milestones: Left-over from 2013, A few very old issues Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Development

No branches or pull requests

6 participants