-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine Vision: Do all font styles have the same visible height at all point sizes? #120
Comments
Issue is back. It is at least issue of WOFF2. I made basic test of Font Size vs Font Weight on CodePen. Font source: Google Fonts. |
Is that an outline geometry issue or is it related to hinting or other aspects of rendering ? I guess it's hinting, right? Can you clarify the problem description, please? |
sounds like a task for @m4rc1e 's browserstack-based tool |
It is related to this: adobe-fonts/source-sans#25 I don't know if this issue is it related to hinting or other aspects of rendering. I want only point out, that visual tests mentioned in this thread are really desirable. |
@felipesanches TrueType hinting |
@felipesanches you mean @m4rc1e 's https://github.com/m4rc1e/pybrowserstack-screenshots right? @miguelsousa from my test it looks that TrueType is OK. For sure there is a problem with WOFF2 (based on OpenType). |
@mattez This one https://github.com/m4rc1e/diffbrowsers, still beta and still awaiting review, googlefonts/diffbrowsers#1 You'll need a paid for Browserstack account to use it. |
Difference is so obvious arount size 28px ... Test i your self with my prototype tester on codepen in your browser.
|
@m4rc1e Am I correct that we plan to integrate your tool as a FontBakery automated test at some point in the near future? If so, then I think we might re-phrase the title of this issue here. |
@felipesanches The tool isn't fast, it really only needs to be run on prs for google/fonts. We should include it but use an optional flag to run it. Something like Speaking of which, here's one I made earlier |
@mattez if this issue only happens with otf-based fonts, there's nothing to fix in them; they already have the same family alignment zones (FamilyBlues & FamilyOtherBlues). Getting the different weights to lineup the way you want may require changes to the rasterizer. |
@mattez also, you compare "WOFF2" vs "TTF" but WOFF and WOFF2 are just wrappers around other file types, like ZIP. What is inside the WOFF2 - also a TTF? Comparing OTF vs TTF can be useful |
I start with test in my most favorite browsers. I'm going to tested on other Platforms and Browsers combinations. |
Here are results from Windows 10. I its looking really fine and OK. So it is probably not problem of font but some problem on operating system or what. system: Windows 10 |
Following #246 ...
Write a machine vision test that ensures all font styles have the same visible height at all point sizes.
Adobe's Source Sans Pro in earlier versions has a bug that reproduces this, adobe-fonts/source-sans#25
The text was updated successfully, but these errors were encountered: