Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofl/molengo: v0.11 added. Fixed OS X validation error. #1369

Closed
wants to merge 1 commit into from
Closed

ofl/molengo: v0.11 added. Fixed OS X validation error. #1369

wants to merge 1 commit into from

Conversation

laerm0
Copy link
Contributor

@laerm0 laerm0 commented Nov 29, 2017

Unspecified validation error on OS X ("System Validation"), but a roundtrip through FontForge fixed it. v0.11 added. Fixes #1305.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 29, 2017

Just ran this pr through diffbrowsers:

Regression Report:

Fonts: ["Molengo-Regular.ttf"]

View: glyphs-all_14pt
PASSED: Desktop_OS_X_El_Capitan_safari_9.1_.jpg is the same
WARNING: Desktop_Windows_7_ie_9.0_.jpg is different by 13482 pixels
WARNING: Desktop_Windows_7_chrome_50.0_.jpg is different by 12391 pixels
WARNING: Desktop_Windows_10_edge_15.0_.jpg is different by 13447 pixels
WARNING: Desktop_Windows_7_firefox_45.0_.jpg is different by 8228 pixels

desktop_windows_10_edge_15 0_
Edge

Regression Report:

Fonts: ["Molengo-Regular.ttf"]

View: waterfall
PASSED: Desktop_OS_X_El_Capitan_safari_9.1_.jpg is the same
WARNING: Desktop_Windows_7_ie_9.0_.jpg is different by 41419 pixels
WARNING: Desktop_Windows_7_chrome_50.0_.jpg is different by 38578 pixels
WARNING: Desktop_Windows_10_edge_15.0_.jpg is different by 41419 pixels
WARNING: Desktop_Windows_7_firefox_45.0_.jpg is different by 26829 pixels

desktop_windows_7_ie_9 0_
ie 9 Win 7
size 8, 16-19 are jumping.

desktop_windows_7_ie_9 0_

Which fonts did you round trip? is round tripping through FontForge changing tables related to the hints?

@laerm0
Copy link
Contributor Author

laerm0 commented Nov 29, 2017

Yeah, I see that. Hm. The hint tables are identical, but it looks like the per-glyph hints are changed. This file was hinted using xgridfit, which I don't know, you probably don't either, and I bet FontForge didn't parse those hints adequately when it imported the file.

Thoughts? This has FF source, so it's kinda easy to go back to the drawing board on it.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 29, 2017

Try running the fonts through FontVal and see if anything suspicious is flagged.

I don't like round tripping since it can destroy other data. I think its best to really work out what is causing this. It also means we can write an FB test so the issue is documented and we have tests to catch this in the future.

@laerm0
Copy link
Contributor Author

laerm0 commented Nov 29, 2017

It crashes FontVal, so whatever it is, it's really in there. OS X font validation only says "System Validation," so that's no help. It passes OTS. check-googlefonts didn't throw up any real errors. A roundtrip through ttx still failed OS X validation. So I was pretty stumped.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 29, 2017

It worked for me:
https://jsbin.com/yajilepeka/edit?output

@laerm0
Copy link
Contributor Author

laerm0 commented Nov 29, 2017

Ah, cool, thanks.

Looks like it's only the OS/2 table that has any real issues, and those are trivial. I don't think either of those would crash validation, but I'll go back to the previous version and fix that and see if it installs in OS X.

@laerm0
Copy link
Contributor Author

laerm0 commented Nov 29, 2017

Taking this font through ttx fails OS X font validation ("serious errors were found with this font"). I think OS X font validation has issues with ttx in general, actually.

Any other ways to edit the OS/2 that don't involve a font editor that you'd recommend?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jul 8, 2019

Version on Google Fonts works just fine in OS X 10.14.3. No issues with Fontbook or ttx.

@m4rc1e m4rc1e closed this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Validation report
2 participants