-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 'missing codepoints' check #1232
Comments
I contacted Nyshadh and he said he did not yet publish his script on google/fonts but that he'll let me know when he does that, so that I can port it / integrate it into fontbakery. |
Thank you nyshadh!
…On Mar 9, 2017 11:25 PM, "Felipe Corrêa da Silva Sanches" < ***@***.***> wrote:
I contacted Nyshadh and he said he did not yet publish his script on
google/fonts but that he'll let me know when he does that, so that I can
port it / integrate it into fontbakery.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP9y4sVyqbWbbRriVpmu1mHugI2hjLOks5rkNC3gaJpZM4MYIb5>
.
|
Sure! As soon as Nyshadh publishes his scripts, I'll port them into FB. |
@davelab6 can you ask Nyshadh for this script again soon, please? |
Nyshadh is out of the office for a few weeks |
Nyshadh may be able to share this end of this week / early next week |
Great, thanks! |
@davelab6 Any further info on this? Maybe a description of what needs to be done? Or a reference implementation. Otherwise, I'll re-categorize this a "MISC"/"maybe-someday" and revisit someday in the future. Presumably there is an implementation by Nyshadh somewhere, so I should not spend time on this issue right now. |
@felipesanches yep - I agree, I moved it to 0.5.0 :) |
thanks! |
I pinged Nyshadh about this again; hopefully will be possible soon :) |
thanks |
Does the OS/2 codepoint coverage part of FontVal does what you want for this? That's all in C# in https://github.com/HinTak/Font-Validator/blob/master/OTFontFileVal/val_OS2.cs line 1160 onwards or thereabouts. |
Thanks! I'll take a look at that later. |
No the OS/2 codepages aren't relevant, but having that set of char checks
in pyfontaine would be nice. Please don't close this until that's resolved
or there is an upstream issue for it
…On Aug 31, 2017 8:37 PM, "Felipe Corrêa da Silva Sanches" < ***@***.***> wrote:
Thanks! I'll take a look at that later.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAP9y8U0S2oOtdpwasQ_H3rZ7i3EGQjDks5sd1HigaJpZM4MYIb5>
.
|
we don't have pyfontaine as a dependency anymore, so I moved this issue to the pyfontaine repo and will close this one. |
Thanks!
|
Nyshadh has written a 'missing codepoints' check that FB should implement
The text was updated successfully, but these errors were encountered: