Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'missing codepoints' check #1232

Closed
davelab6 opened this issue Mar 9, 2017 · 18 comments
Closed

Implement 'missing codepoints' check #1232

davelab6 opened this issue Mar 9, 2017 · 18 comments

Comments

@davelab6
Copy link
Contributor

davelab6 commented Mar 9, 2017

Nyshadh has written a 'missing codepoints' check that FB should implement

@felipesanches
Copy link
Collaborator

I contacted Nyshadh and he said he did not yet publish his script on google/fonts but that he'll let me know when he does that, so that I can port it / integrate it into fontbakery.

@davelab6
Copy link
Contributor Author

davelab6 commented Mar 10, 2017 via email

@felipesanches
Copy link
Collaborator

Sure! As soon as Nyshadh publishes his scripts, I'll port them into FB.

@felipesanches
Copy link
Collaborator

@davelab6 can you ask Nyshadh for this script again soon, please?

@davelab6
Copy link
Contributor Author

davelab6 commented Apr 6, 2017

Nyshadh is out of the office for a few weeks

@davelab6
Copy link
Contributor Author

davelab6 commented May 8, 2017

Nyshadh may be able to share this end of this week / early next week

@felipesanches
Copy link
Collaborator

Great, thanks!

@felipesanches
Copy link
Collaborator

@davelab6 Any further info on this?

Maybe a description of what needs to be done? Or a reference implementation. Otherwise, I'll re-categorize this a "MISC"/"maybe-someday" and revisit someday in the future.

Presumably there is an implementation by Nyshadh somewhere, so I should not spend time on this issue right now.

@davelab6 davelab6 modified the milestones: 0.5.0 Code Is Well Organized, 0.2.0 Binary Checks Are Reliable May 22, 2017
@davelab6
Copy link
Contributor Author

@felipesanches yep - I agree, I moved it to 0.5.0 :)

@felipesanches
Copy link
Collaborator

thanks!

@davelab6
Copy link
Contributor Author

I pinged Nyshadh about this again; hopefully will be possible soon :)

@felipesanches
Copy link
Collaborator

thanks

@davelab6
Copy link
Contributor Author

google/fonts#1108

@davelab6 davelab6 modified the milestones: 0.3.1 - Further improvements on reliability of checks and fixers, 0.5.0 Code Is Well Organized Jul 31, 2017
@HinTak
Copy link

HinTak commented Sep 1, 2017

Does the OS/2 codepoint coverage part of FontVal does what you want for this? That's all in C# in https://github.com/HinTak/Font-Validator/blob/master/OTFontFileVal/val_OS2.cs line 1160 onwards or thereabouts.

@felipesanches
Copy link
Collaborator

Thanks! I'll take a look at that later.

@davelab6
Copy link
Contributor Author

davelab6 commented Sep 1, 2017 via email

@felipesanches felipesanches added this to the 0.3.3 - Future minor release milestone Sep 30, 2017
@davelab6 davelab6 modified the milestones: 0.3.3 (upcoming minor release), 0.3.4 - Future minor release Nov 7, 2017
@felipesanches
Copy link
Collaborator

we don't have pyfontaine as a dependency anymore, so I moved this issue to the pyfontaine repo and will close this one.

@davelab6
Copy link
Contributor Author

davelab6 commented Dec 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants