Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Display a burndown chart of check-results scores per family (on the family details page) #1237

Closed
felipesanches opened this issue Mar 9, 2017 · 3 comments
Assignees

Comments

@felipesanches
Copy link
Collaborator

We do collect all the data needed to build a burndown chart (and there's been some prototypes of that in the past) but right now all we show in the dashboard UI is info tagged with "HEAD": true in the database, meaning that we're just displaying the check results for the latest commit in the git repos.

Since we have the data, I think it would be wise to query that and render the chart. The best place to showcase the graph, in my oppinion, would be at the top of the family details page, where nowadays we only render the check-results summary pie-chart as seen in the screenshot below:

selecao_746

@felipesanches felipesanches self-assigned this Mar 9, 2017
@felipesanches felipesanches changed the title Display Burndown chart on the dashboard Display burndown chart on the dashboard Mar 9, 2017
@davelab6
Copy link
Contributor

davelab6 commented Mar 10, 2017 via email

@davelab6 davelab6 modified the milestone: 0.3.0 Collection Dashboard Web UI Apr 18, 2017
@felipesanches felipesanches changed the title Display burndown chart on the dashboard Dashboard: Display a burndown chart of check-results scores per family (on the family details page) Apr 28, 2017
@felipesanches
Copy link
Collaborator Author

It costs too much to run FB on the full commit history of projects, so nowadays we are only checking against the repo HEAD commit.

In order to make it acceptable to keep the full history, we would need to detect whether re-running the checks on a specific commit is really necessary. The criteria for deciding that would be: (a) the specific commit was never checked previously or (b) it was checked with an older version of fontbakery so it would be needed to re-run the checks and update the database entries.

@felipesanches
Copy link
Collaborator Author

Migrating to fontbakery-dashboard issue tracker per #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants