Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display results for production font files on the dashboard #1239

Closed
felipesanches opened this issue Mar 9, 2017 · 8 comments
Closed

Display results for production font files on the dashboard #1239

felipesanches opened this issue Mar 9, 2017 · 8 comments
Assignees

Comments

@felipesanches
Copy link
Collaborator

Wee need to decide how the check results for the production font files will be displayed on the dashboard. And then I need to implement whatever we decide.

I understand that we'll probably want to have the same level of detail for production files as we have with upstream git-repo files. So Ideally we would simply populate the same page template we already have. On the other hand, we'll probably want to compare side-by-side production against upstream.

@davelab6 do we need to compare in the single-font-file/individual-checks level ?
I can see the value of being able to observe in a glance that a certain check fails on upstream while passing on production (or vice versa).

We may also want to see a comparison in the global level like displaying the progress bars for the check-results summary of prod and upstream side-by-side somewhere in the UI.

This issue is focused on brainstorming this and later implementing it. For tracking the task of implementing the actual server-side fontbakery run on prod files we already have #1238

@davelab6
Copy link
Contributor

davelab6 commented Apr 6, 2017

do we need to compare in the single-font-file/individual-checks level ?

Yes, I think so

We may also want to see a comparison in the global level

Also yes

@felipesanches
Copy link
Collaborator Author

The idea at the moment is that for each check that diverges between prod and upstream I'll place an icon (in an additional column of the check results table) meaning either "fixed upstream" or "broken upstream / regression"

Then, globally, I'll add to the page header a up/down arrows with the percentages of upstream fixes and of upstream regressions.

@felipesanches
Copy link
Collaborator Author

felipesanches commented Apr 18, 2017

well... simple strings "upstream regression / fixed upstream" per check result would be enough actually. And maybe even more efficient at communicating their meaning, perhaps. I think I'll only use icons for the up/down percentage arrows.

@davelab6
Copy link
Contributor

That's fine - these kinds of "UX" decisions don't matter at the moment, just anything that 'works' is fine for me at this time :)

@davelab6
Copy link
Contributor

davelab6 commented May 2, 2017

I'm re-opening this for @graphite to consider the UI aspects later :)

@felipesanches
Copy link
Collaborator Author

OK, cool. But did you mean @graphicore ?

@graphicore
Copy link
Collaborator

I felt addressed :-)

@felipesanches
Copy link
Collaborator Author

Migrating to fontbakery-dashboard issue tracker per #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants