Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why some git_repos fail to run fbakery on container-engine #1240

Closed
3 tasks done
felipesanches opened this issue Mar 9, 2017 · 4 comments
Closed
3 tasks done

Investigate why some git_repos fail to run fbakery on container-engine #1240

felipesanches opened this issue Mar 9, 2017 · 4 comments
Assignees
@felipesanches
Labels
P2 Important

Comments

@felipesanches
Copy link
Collaborator

felipesanches commented Mar 9, 2017 •
edited
Loading

I've setup the dispatcher to queue 34 git repos for processing by the worker container.

When the workers run, some of these font projects fail to be properly checked by fontbakery. From 34 projects, only 21 show up in the dashboard UI.

  • list which are the specific families for which this happens
  • inspect the worker container logs to try to identify the root cause
  • fix it :-)
@felipesanches felipesanches self-assigned this Mar 9, 2017
@felipesanches felipesanches mentioned this issue Mar 9, 2017
Closed
@felipesanches
Copy link
Collaborator Author

These are the families (from our initial selection of 34 font repos) that are failing to run fontbakery on the worker container:

@felipesanches
Copy link
Collaborator Author

OK. I just noticed a pattern! These are the families that place the font files right in the root dir. The issue must be related to the way I extract the font-files directory path. I'll surely find a bug in there and fix it :-)

@felipesanches
Copy link
Collaborator Author

yes, indeed!

@davelab6
Copy link
Contributor

davelab6 commented Mar 27, 2017 via email

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Mar 28, 2017
@felipesanches
several fixes to the dockerized app:
23ecd19 
* updating Dockerfile to accomodate recent refactoring that has split code into multiple external modules
* the most common reason for failing to run fontbakery on the worker container was that the git log command was not including the HEAD commit of the git tree.
* fixed some more bad unicode string handling
* updated the deploy script
* added a workaround for TargetFont not being JSON-serializable (when outputing check-results in JSON format)
(fix issue fonttools#1240)
@felipesanches felipesanches mentioned this issue Mar 28, 2017
Merged
@felipesanches felipesanches mentioned this issue Aug 28, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
P2 Important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felipesanches @davelab6