Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Enable setting it up to run checks on other collections of font families #1286

Closed
m4rc1e opened this issue Apr 21, 2017 · 5 comments

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Apr 21, 2017

Since we can now see the health of the whole collection, how about we allow the dashboard to look at different forks? This will give us the ability to see if a pr will improve the collection before we merge.

I'm working on a collection wide hotfix, google/fonts#641. This would be incredibly useful.

@felipesanches
Copy link
Collaborator

Yes, I agree.

There are some challenges to achieve that, though.

The current implementation of the worker container involves checking out the last N commits of the full git repo of an upstream project and it expects to have a single family per repo. Multiple families in a single repo are handled by having multiple entries on the fontprojects.csv for the same repo, with differing font_prefix values. Loading up additional containers and re-cloning the repo is not so bad since the full size of the upstream font project repos tend to not be very large.

Dealing with the google/fonts git repo (or forks of it) is trickier since that repo is huge! A different approach would be needed for this. We might try fetching raw files from the Github repo via HTTP requests? I tend to dislike this approach.

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Apr 21, 2017

I understand this is no small task.

so the current implementation currently runs on upstream repos or downloadable families from fonts.google.com?

I'm just delving into the worker container to see the current implementation.

@davelab6
Copy link
Contributor

davelab6 commented Apr 21, 2017 via email

@felipesanches
Copy link
Collaborator

A general mechanism for configuring the dashboard is the CSV file on the dispatcher container. If someone needs to setup the dashboard to monitor a different set of families, that can be achieved by providing a different CSV file. But for that, each family must be hosted in its own git repo.

@felipesanches felipesanches changed the title Point dashboard to forks of fonts/google Dashboard: Enable setting it up to run checks on other collections of font families Apr 28, 2017
@davelab6 davelab6 modified the milestone: 0.3.0 Collection Dashboard Web UI Jun 2, 2017
@felipesanches
Copy link
Collaborator

Migrating to fontbakery-dashboard issue tracker per #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants