ofl/*: Incorrect fsType, macStyle and name table settings

[m4rc1e]

We've decided to fix some collection wide problems. I have written a quick and dirty script to locate families which have bad fsType and macStyle values

Bad FsType families:
nanumgothiccoding
exo2
khyay
frijole
playfairdisplay
phetsarath
siemreap
freehand
karla
nanummyeongjo
nanumgothic
averiaseriflibre
nanumbrushscript
bayon
moulpali
content
suwannaphum
myanmarsanspro
averialibre
preahvihear
siamreap
bokor
angkor
baumans
khmer
averiasanslibre
souliyo
padauk
dangrek
titilliumweb
chenla
sansation
battambang
kdamthmor
moul
novamono
taprom
averiagruesalibre
hanna
metal
playfairdisplaysc
nanumpenscript
odormeanchey
kantumruy
notosans
koulen

Bad Mac Style families:
khand
alegreyasans
seoulhangangcondensed
exo2
passionone
share
allan
seoulnamsancondensed
tillana
simonetta
josefinslab
cinzeldecorative
adventpro
rajdhani
orbitron
alegreyasc
alegreyasanssc
kanit
sarpanch
elsie
karma
ruda
abhayalibre
elsieswashcaps
titilliumweb
coustard
overlock
miama
vollkorn
seoulhangang
averiagruesalibre
exo
teko
chivo
cinzel
seoulnamsan
cambay

I'll tidyup and extend the script to hotfix these tomorrow. I need to do further research before I go for the hotfix.

cc @davelab6

[davelab6]

It's not just these two things. Name table screwy-ness, all kinds of things that fontbakery should be able to tell us is broken and can be reliably hotfixed, ideally can be done in one fell swoop

…

On Feb 7, 2017 9:04 AM, "Marc Foley" ***@***.***> wrote: We've decided to fix some collection wide problems. I have written a quick and dirty script <https://gist.github.com/m4rc1e/2085d909c8cd08dc71ee54bbb1d3ccce> to locate families which have bad fsType and macStyle values *Bad FsType families:* nanumgothiccoding exo2 khyay frijole playfairdisplay phetsarath siemreap freehand karla nanummyeongjo nanumgothic averiaseriflibre nanumbrushscript bayon moulpali content suwannaphum myanmarsanspro averialibre preahvihear siamreap bokor angkor baumans khmer averiasanslibre souliyo padauk dangrek titilliumweb chenla sansation battambang kdamthmor moul novamono taprom averiagruesalibre hanna metal playfairdisplaysc nanumpenscript odormeanchey kantumruy notosans koulen *Bad Mac Style families:* khand alegreyasans seoulhangangcondensed exo2 passionone share allan seoulnamsancondensed tillana simonetta josefinslab cinzeldecorative adventpro rajdhani orbitron alegreyasc alegreyasanssc kanit sarpanch elsie karma ruda abhayalibre elsieswashcaps titilliumweb coustard overlock miama vollkorn seoulhangang averiagruesalibre exo teko chivo cinzel seoulnamsan cambay I'll tidyup and extend the script to hotfix these tomorrow. I need to do further research before I go for the hotfix. cc @davelab6 <https://github.com/davelab6> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#641>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP9yz_p-thSAV7449VAfGPEqO5P8wcZks5raKQVgaJpZM4L5xGT> .

[m4rc1e]

@davelab6 yes, fixing the macStyle alone isn't enough.

For hot fixing fonts from 3rd parties. I've always run them through our FB script https://github.com/m4rc1e/fontbakery/blob/master/fontbakery-nametable-from-filename.py

This script will convert the filename into a nametable which complies to our spec. The fsSelection and macStyle bits also get set correctly. I'll rename this issue since the scope has changed a little.

[davelab6]

I'll rename this issue since the scope has changed a little.

apache/* fonts also need a look; the ufl/* stuff we can't directly bat on because of the trademark stuff, but we should report anything we would want to do to it :)

[m4rc1e]

@davelab6 Thanks, I'll implement this.

[davelab6]

Now that @felipesanches 's dashboard shows all families in production, it would be great if @m4rc1e can go over the FB errors and ensure they are classified correctly, especially the 'critical' ones, so that then those bugs can be hot fixed along with the above 3 (fsSelection, macStyle, name table) so the effort to push 100+ family updates doesn't have to be repeated

[m4rc1e]

Just to point out, FB has an overview page. I can now see the total number of families which are failing on certain issues.

I propose the collection wide hotfix to solve the following issues:

• Name tables
  • Add Mac fields if missing. Some fonts only have Windows entries
  • License and License url fields are correct
  • Update Copyright to reflect new standard
  • Font version and head version are consistent
• FsType and macStyle bits
  • Correct bits selected, depending on style
• Font Tables
  • Remove unwanted tables such as kern when a gpos table is present
• License txt files
  • first line of OFL.txt to be new Copyright string
• Hinting
  • Fix the gasp table

I really dislike hot fixes and prefer to do these things at the source level. However, many sources are non existent or need to be derived from other sources. This hotfix solution needs to be more than a mere hammer. It should be a sanitiser that can be used on all families, when they're being onboarded :-).

cc @graphicore @felipesanches @davelab6

[davelab6]

@m4rc1e @graphicore @felipesanches before I start merging in all the PRs that Marc has made to address some of these issues, I'd like to have a FB dashboard that can track the progress of the fix from PR here to production; and to know that the hotfixes are comprehensive, such that we won't need to do another round of pushing 100s of families again in the near future. Thoughts? :)

[laerm0]

Hey @davelab6 @m4rc1e @felipesanches @graphicore , I've got this on my to-do list. I figured I'd check in with what's up with FB and the dashboard now before I come up with a plan.

[davelab6]

The dashbaord will be ready in a few more weeks I guess However the point of this issue is that all the collection passes a few "highest priority" checks. You should be able to determine if this is true today using fb command line tools, and if it's not, just list here what is broken. Thomas Linard posted a nice issue over the weekend with ftxvalidator results in the same vein. On Nov 20, 2017 2:47 PM, "Micah Stupak" <notifications@github.com> wrote: Hey @davelab6 <https://github.com/davelab6> @m4rc1e <https://github.com/m4rc1e> @felipesanches <https://github.com/felipesanches> @graphicore <https://github.com/graphicore> , I've got this on my to-do list. I figured I'd check in with what's up with FB and the dashboard now before I come up with a plan. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#641 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP9ywm0I70BYXdIsTXA2Kj4dXjqpDg9ks5s4ddQgaJpZM4L5xGT> .

[laerm0]

Ah, okay, thanks. I'll look into what @thlinard posted tomorrow.

[m4rc1e]

@laerm0 @davelab6 In March I wrote a collection hotfixer which fixed fsType, fsSelection, usWeightClass and nametables, https://github.com/m4rc1e/gf-hotfix. Due to the urgency, it isn't polished.

More than happy to have a hangout to define the problem better.