-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ERROR on ligatures conditional #1596
Comments
Some example of offending files from the Google Fonts collection are:
|
Given the errors happen directly when TTX'ing the fonts, I propose to update the checker runner so that if fontTools fails to unpack a font, that is a FAIL of the check, not an ERROR, because its not a problem with our code, its a problem with the font that this check has uncovered. I see in the runner's output the string, |
set of ligatures data. (issue fonttools#1596)
in a few rare occasions, we get an ERROR on the ligatures conditional (which is required in tests such as com.google.fonts/test/064, the caret positioning test). This happens on only 7 of the 2400 TTFs in Google Fonts collection:
The actual error is this:
The condition implementation fails at line 2291:
https://github.com/googlefonts/fontbakery/blob/527dda3e1e5b3364512852a6d63dd7745273a6cc/Lib/fontbakery/specifications/googlefonts.py#L2287-L2300
Interestingly, when trying to use ttx to inspect the file contents I get a similar error, which makes me believe this is a case of corrupted TTF files:
This may also be a fontTools bug. Can you confirm that, @behdad ?
The text was updated successfully, but these errors were encountered: