Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTFAutohint 'name' table details #1773

Closed
davelab6 opened this issue Apr 5, 2018 · 9 comments
Closed

TTFAutohint 'name' table details #1773

davelab6 opened this issue Apr 5, 2018 · 9 comments
Assignees
Milestone

Comments

@davelab6
Copy link
Contributor

davelab6 commented Apr 5, 2018

It is critically important that all TTFs in the API have their TTFAutohint args in the 'name' table, so that an automated solution can be made to replicate the hinting on subsets, etc.

FB must therefore have a FAILing check for this (likely coded similar to the copyright notice check) and this is a high priority thing for the @graphicore dashboard to track across the publication flow for all families.

@felipesanches
Copy link
Collaborator

Sure! I'll do it :-D

(I agree this is very important stuff)

@felipesanches felipesanches self-assigned this Apr 5, 2018
@felipesanches felipesanches added this to the 0.4.0 - Future major release milestone Apr 5, 2018
@graphicore
Copy link
Collaborator

Is that a feature request, to highlight/track specific check results?

@felipesanches
Copy link
Collaborator

felipesanches commented Apr 5, 2018

I think it is just a feature request for a new check. But it might be a feature request for highlighting specific results on the dashboard if you decide to fill an issue at https://github.com/googlefonts/fontbakery-dashboard ;-)

By the way, we do have a sketch of a metadata schema for check "priorities". But we never really tagged a significant amount of checks with these specific metadata fields.

@graphicore
Copy link
Collaborator

By the way, we do have a sketch of a metadata schema for check "priorities". But we never really tagged a significant amount of checks with these specific metadata fields.

Yeah, and we don't use it all. If we decide to use it e.g. for this kind of thing, we may end up putting priorities on general checks that who are ours, but not those of other users ...

In this case, the check is of course google fonts specific and the clash of priority preferences is far away of becoming real.

@felipesanches
Copy link
Collaborator

I do not wish to over-complicate things here, but I acknowledge that priority-sorting seems like a user-specific setting rather than an absolute truth that is valid for everyone...

@felipesanches
Copy link
Collaborator

Our current implementation of check/056 does already detect when ttfautohint versioning is lacking on the name table entries. But it emits an INFO:

screenshot at 2018-04-12 17 53 14

We can make it a FAIL.

@felipesanches
Copy link
Collaborator

And explicitly state why in the FAIL message.

@felipesanches
Copy link
Collaborator

The current check only tries to parse ttfautohint version info, but not the args:

installed_ttfa = re.search(r'ttfautohint ([^-\n]*)(-.*)?\n',
                             ttfa_output).group(1)

We probably would want to parse the args as well.

@felipesanches
Copy link
Collaborator

That's the current state of the collection, regarding availability of the ttfautohint params on version strings of the name table:

screenshot at 2018-08-22 23 51 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants