Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subfamily Name Italic check applies in all correct profiles #3666

Closed
4 of 5 tasks
Tracked by #3611
RosaWagner opened this issue Mar 17, 2022 · 1 comment 路 Fixed by #4016
Closed
4 of 5 tasks
Tracked by #3611

Subfamily Name Italic check applies in all correct profiles #3666

RosaWagner opened this issue Mar 17, 2022 · 1 comment 路 Fixed by #4016
Assignees
@yanone
Labels
P1 Quick
Milestone
0.8.11

Comments

@RosaWagner
Copy link
Contributor

RosaWagner commented Mar 17, 2022 •
edited by vv-monsalve

Should be triggered if "Italic" is part of the file name, or NameID2, or NameID17.
The ticked cases indicates where you can already find it.

Name ID2 in name table should be "Italic" (or "Bold Italic")

馃敟 FAIL: Check name table: FONT_SUBFAMILY_NAME entries.
* [com.google.fonts/check/name/subfamilyname](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/subfamilyname)
馃敟 FAIL SUBFAMILY_NAME for Win "Regular" must be "Italic" [code: bad-familyname]

Profile

  • in google-font profile
  • in universal profile
  • in opentype profile

Format

  • in VF check
  • in static check
@RosaWagner RosaWagner mentioned this issue Mar 17, 2022
Closed
10 tasks
@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Mar 23, 2022 •
edited

Profiles where it should be included

  • in google-font profile
  • in universal profile
  • in opentype profile

Log level result: FAIL

@RosaWagner RosaWagner added this to the 0.8.12 milestone Sep 22, 2022
@yanone yanone mentioned this issue Jan 13, 2023
Merged
3 tasks
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.11 Jan 13, 2023
@yanone yanone linked a pull request Jan 13, 2023 that will close this issue
Introduce italic name checks in OpenType profile #4016
Merged
3 tasks
felipesanches pushed a commit that referenced this issue Jan 17, 2023
@yanone @felipesanches
New check: com.google.fonts/check/name/italic_names
b7050bb 
Check name table IDs 1, 2, 16, 17 to conform to Italic style.

This check ensures that several entries in the name table
conform to the font's Upright or Italic style,
namely IDs 1 & 2 as well as 16 & 17 if they're present.

(issues #3666 and #3667)
felipesanches pushed a commit that referenced this issue Jan 17, 2023
@yanone @felipesanches
New check: com.google.fonts/check/name/italic_names
d041b2e 
Check name table IDs 1, 2, 16, 17 to conform to Italic style.

This check ensures that several entries in the name table
conform to the font's Upright or Italic style,
namely IDs 1 & 2 as well as 16 & 17 if they're present.

(issues #3666 and #3667)
felipesanches pushed a commit that referenced this issue Jan 17, 2023
@yanone @felipesanches
New check: com.google.fonts/check/name/italic_names
9824d7e 
Check name table IDs 1, 2, 16, 17 to conform to Italic style.

This check ensures that several entries in the name table
conform to the font's Upright or Italic style,
namely IDs 1 & 2 as well as 16 & 17 if they're present.

(issues #3666 and #3667)
@colinmford colinmford mentioned this issue Feb 17, 2023
Closed
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Mar 3, 2023
@felipesanches
disable check/italic_names prior to v0.8.11 release
4b3955f 
Proposed for inclusion at issue fonttools#3666
But concerns were brought up at issue fonttools#4061
So we should address that before re-enabling this.
@felipesanches felipesanches mentioned this issue Mar 3, 2023
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Mar 3, 2023
@felipesanches
disable check/italic_names prior to v0.8.11 release
1e71b2c 
Proposed for inclusion at issue fonttools#3666
But concerns were brought up at issue fonttools#4061
So we should address that before re-enabling this.
felipesanches added a commit that referenced this issue Mar 3, 2023
@felipesanches
disable check/italic_names prior to v0.8.11 release
37c1640 
Proposed for inclusion at issue #3666
But concerns were brought up at issue #4061
So we should address that before re-enabling this.
felipesanches pushed a commit that referenced this issue Mar 10, 2023
@yanone
New Check: com.google.fonts/check/name/italic_names
6ace52c 
Added to the Open Type Profile
(issues #3666 and #3667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanone yanone

Labels
P1 Quick
Projects
None yet
Milestone
0.8.11
Development

Successfully merging a pull request may close this issue.

Introduce italic name checks in OpenType profile fonttools/fontbakery
4 participants
@yanone @felipesanches @RosaWagner @vv-monsalve