Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fvar check proposal: Instance records must have the same size #3705

Closed
miguelsousa opened this issue Apr 12, 2022 · 0 comments
Closed

fvar check proposal: Instance records must have the same size #3705

miguelsousa opened this issue Apr 12, 2022 · 0 comments
Assignees
@miguelsousa
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone
0.8.9

Comments

@miguelsousa
Copy link
Contributor

Quote from the fvar documentation in OpenType spec v1.9 (my emphasis):

All of the instance records in a given font must be the same size, with all either including or omitting the postScriptNameID field. [...]
If the value is 0xFFFF, then the value is ignored, and no PostScript name equivalent is provided for the instance.

I hereby propose a new fvar check that validates that all of the instance records in a given font must have the same size.
The check should FAIL if the conditions are not met.
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Apr 12, 2022
@miguelsousa miguelsousa mentioned this issue Apr 14, 2022
Merged
felipesanches pushed a commit that referenced this issue Apr 15, 2022
@miguelsousa @felipesanches
New check: com.adobe.fonts/check/varfont/same_size_instance_records
61ff1cb 
Added to the OpenType Profile
Validates that all of the instance records in a given font have the same size, with all either including or omitting the postScriptNameID field
(issue #3705)
@felipesanches felipesanches added this to the 0.8.9 milestone Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelsousa miguelsousa

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Milestone
0.8.9
Development

No branches or pull requests
2 participants
@felipesanches @miguelsousa