Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adobe Fonts profile: Check that nameID 1 supports English language in Windows platform #3714

Closed
miguelsousa opened this issue Apr 14, 2022 · 2 comments
Closed

Adobe Fonts profile: Check that nameID 1 supports English language in Windows platform #3714

miguelsousa opened this issue Apr 14, 2022 · 2 comments
Assignees
@miguelsousa
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone
0.8.9

Comments

@miguelsousa
Copy link
Contributor

miguelsousa commented Apr 14, 2022 •
edited

Add a new check for nameID 1 (Font Family name), platformID 3 (Windows), encodingID 1 (Unicode), languageID 1033/0x409 (US-English).
Yield FAIL if string is empty or None, and PASS otherwise.
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Apr 19, 2022
@felipesanches
Copy link
Collaborator

@miguelsousa This sounds like a very generic check. What's the rationale? It may be good for inclusion in the universal profile.

@miguelsousa
Copy link
Contributor Author

The rationale is that there's a part of our pipeline that requires it 😅
I wouldn't mind including it in the Universal profile, but it might become an unnecessary requirement for other people's workflow.

@miguelsousa miguelsousa mentioned this issue Apr 20, 2022
Merged
felipesanches pushed a commit that referenced this issue Apr 20, 2022
@miguelsousa @felipesanches
New check: com.adobe.fonts/check/nameid_1_win_english
9436e9d 
Added to the Adobe Fonts Profile
Validates that the font has a good nameID 1, Windows/Unicode/US-English `name` table record
(issue #3714)
@felipesanches felipesanches added this to the 0.8.9 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelsousa miguelsousa

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Milestone
0.8.9
Development

No branches or pull requests
2 participants
@felipesanches @miguelsousa