Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new check: Fonts must have neither or both the tables COLR,SVG #3886

Closed
felipesanches opened this issue Aug 25, 2022 · 0 comments
Closed

new check: Fonts must have neither or both the tables COLR,SVG #3886

felipesanches opened this issue Aug 25, 2022 · 0 comments
Assignees
@felipesanches
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone
0.8.11

Comments

@felipesanches
Copy link
Collaborator

@rsheeter said "Fonts must have neither or both the tables COLR,SVG".

Rod, how would we explain that to a fontbakery user? Is there a relatively short (but as detailed as it might be needed to be clear) piece of text that justifies/explains this requirement?

I would then use this as rationale text in the implementation of this newly proposed check.

I also presume this is a Google-specific requirement, so I will place this check on the Google Fonts profile. Otherwise, please let me know if you consider this to be a more general check.
@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Aug 25, 2022
@felipesanches felipesanches added this to the 0.8.11 milestone Aug 25, 2022
@felipesanches felipesanches self-assigned this Aug 25, 2022
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
7f2a071 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
@felipesanches felipesanches mentioned this issue Aug 25, 2022
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
e7402d9 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
97d4d76 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
88e3ca5 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
0adbcff 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
6403779 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
58fe813 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
45a9e26 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
780dee9 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Aug 25, 2022
@felipesanches
New Check: check/colorfont_tables
88f7725 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue fonttools#3886)
felipesanches added a commit that referenced this issue Aug 26, 2022
@felipesanches
New Check: check/colorfont_tables
a35b5f7 
"Fonts must have neither or both the tables `COLR` and `SVG`."
com.google.fonts/check/colorfont_tables

Added to the Google Fonts Profile.
(issue #3886)
@rsheeter rsheeter mentioned this issue May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Milestone
0.8.11
Development

No branches or pull requests
1 participant
@felipesanches