-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation fault: Python crashes running fontbakery #4143
Comments
My answer assumes that you're using Font Bakery version 0.8.11. The version number can be obtained by running the command The check-adobefonts profile has 79 checks. The list of checks can be obtained by running the command Looking at the progress bar you provided ( In case you need to exclude one or more checks from being executed, use the
|
Hi @miguelsousa Thank you for your answer. Excluding checks from being executed was useful to find where the problem was. After a few tests, I found that python crashes while executing Without this check, all works fine. I’m using FontBakery version 0.8.11. |
Thanks for the info. Do you get any traceback besides the segmentation fault message? Please run
|
I'm able to reproduce the segfault with SourceSerif4Variable-Italic.ttf and |
Hi @miguelsousa I just got the segmentation fault message: I was using Thank you so much. |
I'd like to keep this open until there's a fix on the freetype-py side. |
I’m hitting this issue, too. It also works when I roll back to |
and update to the CHANGELOG.md (issues fonttools#4143, fonttools#3715 and fonttools#3874)
Adobe should have been added to this file a long time ago in the fontbakery project, since the Google CLA doesn't take copyright assignment, so Adobe is a copyright holder for the contributions made by Adobe employees. Also, the following commits were authored by Miguel Sousa at his Open Bakery repository and ported back to Font Bakery: These commits are identified by their hashes, as agreed on a conversation with Miguel at fonttools#4144 (comment) - Commit a328639: Run black on the codebase (discussions fonttools#3397) note: To be sure, I have run the black code formatter myself on the codebase instead of applying a patch from the Open Bakery repo. There were a few strings that were placed side-by-side on the same line, which pylint caught. I made a followup commit to fix this and a few other minor lints. (My pylint fixes: commit c2daa50) - Commit 413977d: Adopted the sentence "A font quality assurance tool for everyone" as package description on setup.py - Commit 8abeb5c: Bumping up the version number of a few dependencies on requirements.txt, as we do routinely. - Commit 4b2af53: Update setup.py to use extras based on the needs of specific profiles. (issue fonttools#3874) Also: - Uses encoding="utf8" when opening the README.md file. - Adds all supported Python versions to classifiers list - Commit 194613e: Added code-test for crash on freetype-py 2.4.0 (issue fonttools#4143) I have also updated the CHANGELOG.md with release notes for the upcoming version v0.9.0 (issues fonttools#3715 and fonttools#3874) - Commit ea4c774: Updated versions of dependencies used for code-testing - Commit 000d806: Update actions/setup-python action to v4 - Commit b73a3d2: update CONTRIBUTING.md The full update written by Miguel was incorporated because I believe it is a good set of guidelines for the project. Note: The text regarding the Google CLA (that was present in the original CONTRIBUTING.md before Miguel's new text) was preserved. - Commit 328dc21: Enable publish job to create GitHub release. note: Miguel removed the letter 'v' prefix on release tags (such as v0.8.12) but I changed it back to using the letter, for the sake of consistency with all pre-existing release tags in this repo.
Adobe should have been added to this file a long time ago in the fontbakery project, since the Google CLA doesn't take copyright assignment, so Adobe is a copyright holder for the contributions made by Adobe employees. Also, the following commits were authored by Miguel Sousa at his Open Bakery repository and ported back to Font Bakery: These commits are identified by their hashes, as agreed on a conversation with Miguel at fonttools#4144 (comment) - Commit a328639: Run black on the codebase (discussions fonttools#3397) note: To be sure, I have run the black code formatter myself on the codebase instead of applying a patch from the Open Bakery repo. There were a few strings that were placed side-by-side on the same line, which pylint caught. I made a followup commit to fix this and a few other minor lints. (My pylint fixes: commit c2daa50) - Commit 413977d: Adopted the sentence "A font quality assurance tool for everyone" as package description on setup.py - Commit 8abeb5c: Bumping up the version number of a few dependencies on requirements.txt, as we do routinely. - Commit 4b2af53: Update setup.py to use extras based on the needs of specific profiles. (issue fonttools#3874) Also: - Uses encoding="utf8" when opening the README.md file. - Adds all supported Python versions to classifiers list - Commit 194613e: Added code-test for crash on freetype-py 2.4.0 (issue fonttools#4143) I have also updated the CHANGELOG.md with release notes for the upcoming version v0.9.0 (issues fonttools#3715 and fonttools#3874) - Commit ea4c774: Updated versions of dependencies used for code-testing - Commit 000d806: Update actions/setup-python action to v4 - Commit b73a3d2: update CONTRIBUTING.md The full update written by Miguel was incorporated because I believe it is a good set of guidelines for the project. Note: The text regarding the Google CLA (that was present in the original CONTRIBUTING.md before Miguel's new text) was preserved. - Commit 328dc21: Enable publish job to create GitHub release. note: Miguel removed the letter 'v' prefix on release tags (such as v0.8.12) but I changed it back to using the letter, for the sake of consistency with all pre-existing release tags in this repo. Dave Crossland convinced me afterwards that it is actually a good idea to drop the prefix, so I will do it in a followup commit, with the intention of keeping both repos as close to identical as possible.
Adobe should have been added to this file a long time ago in the fontbakery project, since the Google CLA doesn't take copyright assignment, so Adobe is a copyright holder for the contributions made by Adobe employees. Also, the following commits were authored by Miguel Sousa at his Open Bakery repository and ported back to Font Bakery: These commits are identified by their hashes, as agreed on a conversation with Miguel at #4144 (comment) - Commit a328639: Run black on the codebase (discussions #3397) note: To be sure, I have run the black code formatter myself on the codebase instead of applying a patch from the Open Bakery repo. There were a few strings that were placed side-by-side on the same line, which pylint caught. I made a followup commit to fix this and a few other minor lints. (My pylint fixes: commit c2daa50) - Commit 413977d: Adopted the sentence "A font quality assurance tool for everyone" as package description on setup.py - Commit 8abeb5c: Bumping up the version number of a few dependencies on requirements.txt, as we do routinely. - Commit 4b2af53: Update setup.py to use extras based on the needs of specific profiles. (issue #3874) Also: - Uses encoding="utf8" when opening the README.md file. - Adds all supported Python versions to classifiers list - Commit 194613e: Added code-test for crash on freetype-py 2.4.0 (issue #4143) I have also updated the CHANGELOG.md with release notes for the upcoming version v0.9.0 (issues #3715 and #3874) - Commit ea4c774: Updated versions of dependencies used for code-testing - Commit 000d806: Update actions/setup-python action to v4 - Commit b73a3d2: update CONTRIBUTING.md The full update written by Miguel was incorporated because I believe it is a good set of guidelines for the project. Note: The text regarding the Google CLA (that was present in the original CONTRIBUTING.md before Miguel's new text) was preserved. - Commit 328dc21: Enable publish job to create GitHub release. note: Miguel removed the letter 'v' prefix on release tags (such as v0.8.12) but I changed it back to using the letter, for the sake of consistency with all pre-existing release tags in this repo. Dave Crossland convinced me afterwards that it is actually a good idea to drop the prefix, so I will do it in a followup commit, with the intention of keeping both repos as close to identical as possible.
Observed behaviour
I am trying to run check-adobefonts on a TT variable font, but when it gets to 24%, Python crashes showing the same window of issue #3918
Similar to that issue, this is what the terminal shows:
▒ [PPPPPPPPWPWPPPIPPPS............................................................] 24%
zsh: segmentation fault fontbakery check-adobefonts --verbose
However, unlike what was previously reported, making a new virtual environment didn’t fix the problem. I have also tried force-reinstalling fontbakery, and the problem persists.
What can I do about it?
The text was updated successfully, but these errors were encountered: