Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFL website has a new URL and FontBakery should be aware of it #4358

Closed
felipesanches opened this issue Dec 6, 2023 · 10 comments
Closed

OFL website has a new URL and FontBakery should be aware of it #4358

felipesanches opened this issue Dec 6, 2023 · 10 comments

Comments

@felipesanches
Copy link
Collaborator

According to google/fonts#7062, FontBakery checks should accept the new URL for the OFL website.

@n7s
Copy link

n7s commented Dec 7, 2023

Ideally the new URL should be accepted but also a WARN emitted when the old one is found with a suggestion to move to the new URL. We (SIL) have put redirects in place from the old to the new URL and they will probably be around for a good while but users should start moving to the new URL when they get a chance.

@n7s
Copy link

n7s commented Dec 7, 2023

I have the beginning of a check for that. I'm learning the subtleties of FontBakery, but I'm not able to figure out how to have a check be only a family or repo check. IOW it's giving me the results for all the fonts in the folder so the report info is duplicated, any pointers, thanks.

@n7s
Copy link

n7s commented Dec 7, 2023

This is as far as I got:
is_OFL_URL_current-check

@felipesanches felipesanches changed the title OFL website has a new URL and FonBakery should be aware of it OFL website has a new URL and FontBakery should be aware of it Dec 7, 2023
@felipesanches
Copy link
Collaborator Author

Cool! Please submit your work-in-progress as a pull request and I can help you improve it.

@felipesanches
Copy link
Collaborator Author

but I'm not able to figure out how to have a check be only a family or repo check.

I believe you can pass family_directory to the check function so that it will run only once per family dir. But we can double check that together once you post your code on a pull request.

@n7s
Copy link

n7s commented Dec 7, 2023

Thanks, I will prep the PR very soon. I really appreciate all your work on FontBakery! In our current workflow we run FontBakery with a wildcard over all generated fonts in a single project, so even if I use family_directory, I get the repeated results per font. Looking forward to finding a workaround or a better solution.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jan 12, 2024

I've just amended the license_url check so a warn is raised if the old url is used, b297247

felipesanches pushed a commit that referenced this issue Jan 12, 2024
New OFL website URL is expected, while the old one emits a WARN

com.google.fonts/check/name/license_url
On the Google Fonts Profile
(issue #4358)
@felipesanches felipesanches added this to the 0.10.9 milestone Jan 12, 2024
@felipesanches
Copy link
Collaborator Author

thanks, everybody ;-)

felipesanches pushed a commit that referenced this issue Jan 12, 2024
New OFL website URL is expected, while the old one emits a WARN

com.google.fonts/check/name/license_url
On the Google Fonts Profile
(issue #4358)
@simoncozens
Copy link
Collaborator

Hi @n7s, any progress on that PR? If you want to put up what you have, I would be happy to take it over.

@simoncozens
Copy link
Collaborator

Sorry, we're fine, the PR from Dave got merged before I saw this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants