-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com.google.fonts/check/article/images] should pass if there is not an article/images
dir
#4703
Comments
It is just a WARN... for the sake of moving the repo towards some more homogeneous structure.
I'd say there's some benefit for tooling and for user-friendliness to have a more regular directory structure. |
@nathan-williams, I'd be glad to hear your thoughts here as well. What do you think? |
We are not currently using an "images" folder, so having it would be kind of the outlier
It would require changing the paths in multiple HTML article files, which would be time-consuming on something that is not a strong requirement or need. @emmamarichal, @m4rc1e, @yanone wdyt? |
@vv-monsalve I agree. I've never seen a sub-dir called "images". What would that include, having another sub-folder for GIFS? videos? |
ok, no worries. I'll make the proposed change, then. |
com.google.fonts/check/article/images On the Google Fonts profile. (issue fonttools#4703)
com.google.fonts/check/article/images On the Google Fonts profile. (issue fonttools#4703)
com.google.fonts/check/article/images On the Google Fonts profile. (issue #4703)
Observed behavior
The above Warn was reported on this CI run. However, in this comment on the issue proposal for a new check, Nathan Williams said the
images
subdirectory is not required.Expected behavior
The check should pass if there is no
images
subdirectory under thearticle
one (not reporting a Warn).Resources and steps needed to reproduce
See CI run linked above
The text was updated successfully, but these errors were encountered: