Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start of the check-adobe-fonts profile #2369

Merged
merged 2 commits into from Mar 5, 2019
Merged

start of the check-adobe-fonts profile #2369

merged 2 commits into from Mar 5, 2019

Conversation

cjchapman
Copy link
Member

(more checks to come later)

@cjchapman
Copy link
Member Author

@felipesanches Please let me know if there's a better way to handle importing com_google_fonts_check_040 and com_google_fonts_check_042 into adobe_fonts.py.

@felipesanches
Copy link
Collaborator

Great! Thanks!

@felipesanches
Copy link
Collaborator

It looks good. I agree that there could be a better way of including those two checks. Maybe something similar to spec_imports. I will merge this now and we can later try to figure out a better solution for those 2 checks. Thanks, @cjchapman

@felipesanches felipesanches merged commit b81a323 into master Mar 5, 2019
@felipesanches felipesanches added this to the 0.6.12 milestone Mar 5, 2019
@cjchapman cjchapman deleted the cjc-start-of-adobe-fonts-profile branch March 5, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipesanches felipesanches Awaiting requested review from felipesanches

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjchapman @felipesanches