added two checks: consistent UPM across family, max 4 fonts per name ID 1 #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an adobe-fonts check for consistent units per em across the family an opentype check for max of 4 fonts per family name (i.e. name ID 1)
felipesanches
requested changes
Mar 6, 2019
| @@ -106,6 +109,21 @@ def com_adobe_fonts_check_name_empty_records(ttFont): | |||
| yield PASS, ("No empty name table records found.") | |||
|
|
|||
|
|
|||
| @check( | |||
| id='com.adobe.fonts/check/consistent_upm' | |||
There was a problem hiding this comment.
it would be good to add here a rationale= attribute with an overview of the reasoning behind this check.
| failed = False | ||
| family_names = list() | ||
| for ttFont in ttFonts: | ||
| # family_names.append(ttFont['name'].) |
There was a problem hiding this comment.
Please remove this commented-out line. The code below substituites it.
…4 fonts in font list
felipesanches
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added two checks:
adobe-fontscheck for consistent units per em across the familyopentypecheck for max of 4 fonts per family name (i.e. name ID 1)