Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caveat about ligature caret support in ufo2ft to check rationale #3063

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

arrowtype
Copy link
Contributor

Description

In both Fraunces and Recursive, a current FontBakery WARN is this:

WARN: Are there caret positions declared for every ligature?
--- Rationale ---

All ligatures in a font must have corresponding caret (text cursor) positions
defined in the GDEF table, otherwhise, users may experience issues with caret
rendering.

If using GlyphsApp, ligature carets can be set directly on canvas by accessing
the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard
shortcut.


  • WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

Unfortunately, this makes no mention of the fact that ligature carets currently aren’t supported in the FontMake UFO build process by ufo2ft. So, I just spent quite awhile adding ligature carets to Fraunces, for no (immediate) purpose.

It feels like something which might be worth calling out in the rationale, so that future UFO-based projects can either ignore this WARN for now, or approach adding these in a post-process instead of directly to UFOs.

So, this simply adds the following to the rationale:

If designing with UFOs, (as of Oct 2020) ligature carets are not yet compiled by ufo2ft, and therefore will not build via FontMake. See googlefonts/ufo2ft/issues/329

To Do

This PR is somewhat more for discussion than an immediate suggestion ... do we add this kind of information to rationales, when it has an unknown "expiration date"? Have I written it clearly enough, or should I approach it differently?

If it does seem worth merging, I could later work on these to-do items. Thanks!

  • request a pre-review
  • update CHANGELOG.md
  • wait for checks to pass (except github/pages, which is stuck)
  • request a review

@felipesanches felipesanches merged commit bb539d2 into fonttools:master Oct 16, 2020
@anthrotype
Copy link
Member

The "caret_X" are supported by fontmake, but only when generating straight from .glyphs sources (because glyphsLib writes them in the GDEF table definition in the UFO features.fea). When generating from pure designs pace+UFOs (i.e. not in turn created by glyphsLib), ufo2ft doesn't understand this kind of anchors yet. But it will compile ligature carets if these are defined in the features.fea GDEF table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants