Merge pull request #1954 from fonttools/fix-test_addRuleDescriptor

Fix test_addRuleDescriptor
fonttools · May 13, 2020 · 37beca3 · 37beca3
2 parents abf7093 + b079404
commit 37beca3
Showing 1 changed file with 16 additions and 9 deletions.
diff --git a/Tests/designspaceLib/designspace_test.py b/Tests/designspaceLib/designspace_test.py
@@ -996,23 +996,30 @@ def test_addInstanceDescriptor():
     assert instance.styleMapStyleName == "regular"
 
 
-def test_addRuleDescriptor():
+def test_addRuleDescriptor(tmp_path):
     ds = DesignSpaceDocument()
 
     rule = ds.addRuleDescriptor(
-      name="TestRule",
-      conditionSets=[
-          dict(name='Weight', minimum=100, maximum=200),
-          dict(name='Weight', minimum=700, maximum=900),
-      ],
-      subs=[("a", "a.alt")],
+        name="TestRule",
+        conditionSets=[
+            [
+                dict(name="Weight", minimum=100, maximum=200),
+                dict(name="Weight", minimum=700, maximum=900),
+            ]
+        ],
+        subs=[("a", "a.alt")],
     )
 
     assert ds.rules[0] is rule
     assert isinstance(rule, RuleDescriptor)
     assert rule.name == "TestRule"
     assert rule.conditionSets == [
-        dict(name='Weight', minimum=100, maximum=200),
-        dict(name='Weight', minimum=700, maximum=900),
+        [
+            dict(name="Weight", minimum=100, maximum=200),
+            dict(name="Weight", minimum=700, maximum=900),
+        ]
     ]
     assert rule.subs == [("a", "a.alt")]
+
+    # Test it doesn't crash.
+    ds.write(tmp_path / "test.designspace")