Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[varLib / instancer] leaves DSIG in static instance; should remove #1480

Closed
robmck-ms opened this issue Feb 1, 2019 · 3 comments · Fixed by #2866
Closed

[varLib / instancer] leaves DSIG in static instance; should remove #1480

robmck-ms opened this issue Feb 1, 2019 · 3 comments · Fixed by #2866

Comments

@robmck-ms
Copy link
Contributor

Looks like varLib.mutator does not strip DSIG when generating static instances, thus the instance has the VF's DSIG. If that DSIG was not a dummy DSIG, then the DSIG will be invalid for the static instance. Probably would be good to just strip DSIG or replace it with a dummy.

This is a minor issue since practically nothing validates DSIGs, but anyway...
@behdad
Copy link
Member

behdad commented Feb 3, 2019

Probably same about varLib building VF?

@robmck-ms
Copy link
Contributor Author

Good point. I haven't tried that, but I don't see anything for DSIG in varLIb/init.py for it, so...

@behdad behdad closed this as completed in 9369edb Oct 26, 2022
@behdad
Copy link
Member

behdad commented Oct 26, 2022

Fixed mutator. Reopening to check varLib.

@behdad behdad reopened this Oct 26, 2022
@behdad behdad changed the title [varLib.mutator] leaves DSIG in static instance; should remove [varLib / instancer] leaves DSIG in static instance; should remove Oct 28, 2022
behdad added a commit that referenced this issue Oct 28, 2022
@behdad
[varLib / instancer] Remove DSIG table from font
7a7b2b8 
Fixes #1480
@behdad behdad mentioned this issue Oct 28, 2022
Merged
behdad added a commit that referenced this issue Oct 28, 2022
@behdad
[varLib / instancer] Remove DSIG table from font
4926452 
Fixes #1480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[varLib / instancer] Remove DSIG table from font fonttools/fonttools
2 participants
@behdad @robmck-ms