[varLib] Possible bug in varStore.py?

[justvanrossum]

I am trying to learn how VarStores work, and am running into a bit of source code that looks off, even though I'm not sure I fully understand what's going on there.

Compare this fragment:

fonttools/Lib/fontTools/varLib/varStore.py

Lines 71 to 73 in e4b0486

	if len(self._data.Item) == 0xFFF:
	# This is full. Need new one.
	varDataIdx = None

With this:

fonttools/Lib/fontTools/varLib/varStore.py

Lines 107 to 111 in e4b0486

	inner = len(self._data.Item)
	if inner == 0xFFFF:
	# Full array. Start new one.
	self._add_VarData()
	return self.storeDeltas(deltas)

Shouldn't the former also test for 0xFFFF instead of 0xFFF?

[anthrotype]

yeah, looks like a typo to me

[anthrotype]

ItemVariationData.ItemCount is a uint16 so there can be max 0xFFFF items (deltaset rows) per VarData subtable