-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variationModel.interpolateFromMasters doesn't extrapolate as expected #2843
Comments
at least it appears to be intentional e.g. see the docstring of VariationModel (emphasis mine)
I'm sure @behdad can clarify that. |
What @anthrotype said. Current extrapolation implementation extrapolations the values at -1 and +1. |
Would it be possible to express the hope it would eventually also work for values between [0,1]? |
I have to check the code. I think it's possible, yes. In that case it wouldn't need any specific range and would adapt to the min/max specified. |
This is trivial for one axis, less so for more axes. |
True. In MutatorMath that was a bit of work (lines starting here). This is too specific and can't be re-used for varlib. But I imagine it will be similar enough: a couple of different cases that need to be calculated separately. |
[varLib.models] Attempt to fix #2843 by computing the axis ranges
With
extrapolate=True
there is an issue withvariationModel.interpolateFromMasters
as it clips results in 2 value models. Results are as expected in 3 value models.The text was updated successfully, but these errors were encountered: