Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[designspaceLib] [varLib] Allow FeatureVariations to be processed *after* other features #1747

Merged
merged 10 commits into from
Oct 21, 2019
Merged

[designspaceLib] [varLib] Allow FeatureVariations to be processed *after* other features #1747

merged 10 commits into from
Oct 21, 2019

Commits on Oct 17, 2019

  1. addFeatureVariations(): allow the feature tag to be specified (defaul… 

    …t to 'rvrn'); allow said feature to already exist, in which case we append new lookup indices to the existing feature
    @justvanrossum
    justvanrossum committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    d2ea72c View commit details
    Browse the repository at this point in the history

  2. support multiple <featureTag> features

    @justvanrossum
    justvanrossum committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    db04262 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Implement <rules> attribute 'processing' according to spec update fon… 

    …ttools#1750, as well as the related doc.rulesProcessingLast flag
    @justvanrossum
    justvanrossum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    d42b7d7 View commit details
    Browse the repository at this point in the history

  2. use designspace.rulesProcessingLast flag to determine whether we shou… 

    …ld use 'rvrn' or 'rclt'
    @justvanrossum
    justvanrossum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    0ee3f01 View commit details
    Browse the repository at this point in the history

  3. fix error message, reformatted long line

    @justvanrossum
    justvanrossum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    f9b0457 View commit details
    Browse the repository at this point in the history

  4. perform some testing with <rules processing=...> and doc.rulesProcess… 

    …ingLast
    @justvanrossum
    justvanrossum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    f4925ff View commit details
    Browse the repository at this point in the history

  5. more testing of rules-processing-last

    @justvanrossum
    justvanrossum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    4322a3f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. assume ds is a DesignSpaceDocument instance and therefore is known to… 

    … have the rulesProcessingLast attribute
    @justvanrossum
    justvanrossum committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    7bfeb1a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. Test adding FeatureVariations with an existing 'rclt' feature

    @justvanrossum
    justvanrossum committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    e2bac99 View commit details
    Browse the repository at this point in the history

  2. ooops, forgot to add the expected results file

    @justvanrossum
    justvanrossum committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    76b8517 View commit details
    Browse the repository at this point in the history