Better document rule processing order #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlcctrlv
commented
Aug 12, 2020
Doc/source/designspaceLib/readme.rst
Outdated
| @@ -297,6 +297,8 @@ RuleDescriptor object | |||
| - Each condition is a dict with ``name``, ``minimum`` and ``maximum`` keys. | |||
| - ``subs``: list of substitutions | |||
| - Each substitution is stored as tuples of glyphnames, e.g. ("a", "a.alt"). | |||
| - Note: By default, rules are applied *before* text shaping/OpenType layout. See | |||
| `5.0 rules element`_. | |||
There was a problem hiding this comment.
Sorry, I tried hard but reStructuredText is very hard to use. I can't figure out how to make this link go to § 5.0 rules element but say "the <rules> Attributes section".
There was a problem hiding this comment.
it's ok, I don't know either :)
anthrotype
reviewed
Aug 13, 2020
anthrotype
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2040