update colorLib to latest COLRv1 draft #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update C_O_L_R_test.py accordingly. a
LayerV1Record and Affine2x2 are gone. LayerV1List now contains a list of Paint DAGs Added 4 new Paint formats: PaintGlyph, PaintColorGlyph, PaintTransform and PaintComposite
Not pointed to by an Offset32. Thanks Dominik for spotting this!
continue building all glyphs, accummulate errors and only stop at the end fixup
anthrotype
force-pushed
the
colrv1-latest
branch
from
a0b114a
to
53b0034
Compare
makes code more readable
as proposed in googlefonts/colr-gradients-spec#86 The name of PaintColorGlyph may still change to PaintColorSlice, or PaintColrSlice, or PaintColorGlyphSlice, etc." googlefonts/colr-gradients-spec#87
rsheeter
reviewed
Oct 27, 2020
rsheeter
reviewed
Oct 27, 2020
|
Generally lgtm, couple of nits plus shoudl rename PaintColrGlyph => PaintColrSlice |
rsheeter
approved these changes
Oct 27, 2020
following the latest draft See discussion at googlefonts/colr-gradients-spec#85
anthrotype
force-pushed
the
colrv1-latest
branch
from
d4f92e7
to
e992953
Compare
anthrotype
commented
Nov 4, 2020
rsheeter
force-pushed
the
colrv1-latest
branch
from
f1eb77f
to
6e9dbc0
Compare
rsheeter
force-pushed
the
colrv1-latest
branch
from
6e9dbc0
to
f531038
Compare
rsheeter
force-pushed
the
colrv1-latest
branch
from
ebd0d17
to
97facd9
Compare
anthrotype
commented
Nov 10, 2020
rsheeter
force-pushed
the
colrv1-latest
branch
from
513d537
to
97facd9
Compare
rsheeter
force-pushed
the
colrv1-latest
branch
from
97facd9
to
cf2097f
Compare
rsheeter
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs otData and colorLib implementation with the latest COLRv1 draft spec.