svgLib: handle arc commands with bool flags not separated by space/comma #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some SVG authoring tool write arc commands without any space or comma around the boolean 'large-arc' and 'sweep' flags, leading our svg path parser to choke.
This makes the path parser smarter by special-casing arc command parsing so that it only consumes one character ('0' or '1') for these special boolean flags.
anthrotype
force-pushed
the
svg-arc-flags-no-spaces
branch
from
4a48046
to
aad51ec
Compare
rsheeter
reviewed
Nov 6, 2020
| yield token | ||
| continue | ||
|
|
||
| if arc_cmd: |
There was a problem hiding this comment.
optional, if you are going to branch for arcs you could just write a regex specifically for arc (e.g. flag should be 0/1, has optional whitespace, etc)
rsheeter
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SVG authoring tool write arc commands without any space or comma around the boolean 'large-arc' and 'sweep' flags, leading our svg path parser to choke.
E.g.
A1.2 1.2 0 0122 6.2is currently tokenized as["A", "1.2", "1.2", "0", "0122", "6.2"], whereas it should instead be tokenized as["A", "1.2", "1.2", "0", "0", "1", "22", "6.2"]This PR makes the path parser smarter by special-casing arc command so that we only consume one character ('0' or '1') for these special boolean flags.