Use otData for dict to COLR conversion #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
force-pushed
the
colr_to_from_dicts
branch
from
83ffec6
to
74638ab
Compare
anthrotype
reviewed
Feb 9, 2021
rsheeter
force-pushed
the
colr_to_from_dicts
branch
4 times, most recently
from
e5ff272
to
5fa9d0f
Compare
rsheeter
force-pushed
the
colr_to_from_dicts
branch
from
5fa9d0f
to
ea3a939
Compare
|
I've somehow lost your comment about why meddle with the optional version. Note that I put that back to how it was before. |
rsheeter
force-pushed
the
colr_to_from_dicts
branch
2 times, most recently
from
d3cc857
to
385bb5a
Compare
anthrotype
reviewed
Feb 10, 2021
anthrotype
reviewed
Feb 10, 2021
anthrotype
reviewed
Feb 10, 2021
rsheeter
force-pushed
the
colr_to_from_dicts
branch
3 times, most recently
from
c929f4b
to
6538947
Compare
rsheeter
force-pushed
the
colr_to_from_dicts
branch
from
6538947
to
cf4a408
Compare
anthrotype
reviewed
Feb 11, 2021
anthrotype
reviewed
Feb 11, 2021
anthrotype
reviewed
Feb 11, 2021
|
Made a last few tweaks, ptal, hopefully safe to merge now. |
anthrotype
approved these changes
Feb 12, 2021
anthrotype
reviewed
Feb 12, 2021
rsheeter
force-pushed
the
colr_to_from_dicts
branch
from
0fa0d9b
to
274a753
Compare
Co-authored-by: Cosimo Lupo <cosimo@anthrotype.com>
rsheeter
force-pushed
the
colr_to_from_dicts
branch
from
274a753
to
0353c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing per-format functions is tiresome, try to avoid it by leaning on otData. Setting up as PR because I think it's far enough along it might be convenient to be able to comment.