Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CFF2 dict operators #2249

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Add missing CFF2 dict operators #2249

merged 1 commit into from
Apr 1, 2021

Conversation

punchcutter
Copy link
Collaborator

LanguageGroup and ExpansionFactor were missing from the CFF2 dict operators. Found while building CFF2 variable fonts and seeing that the LanguageGroup settings were disappearing.

@behdad
Copy link
Member

behdad commented Mar 30, 2021

LanguageGroup and ExpansionFactor were missing from the CFF2 dict operators.

What do these two do? I can't find any explanation for them.

Also, is it the case that default values are written out to XML for CFF properties? I expected otherwise.

@punchcutter
Copy link
Collaborator Author

There's some explanation in https://adobe-type-tools.github.io/font-tech-notes/pdfs/5015.Type1_Supp.pdf

I wasn't sure about the default values being written for these. I just copied as-is from the CFF privateDictOperators which have default values that are not None.

@anthrotype anthrotype merged commit 59e4e88 into main Apr 1, 2021
@anthrotype anthrotype deleted the CFF2fix branch April 1, 2021 10:08
@anthrotype
Copy link
Member

it seems that defaults are only used in cffLib while decompiling the table if an operator is missing, but are not taken into account when dumping toXML. This applies more generally, not specifically to CFF2. We may want to file a separate issue about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants