Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[featureVars] Process lookups for features other than rvrn last #3099

Merged
merged 2 commits into from
May 2, 2023
Merged

[featureVars] Process lookups for features other than rvrn last #3099

merged 2 commits into from
May 2, 2023

Conversation

behdad
Copy link
Member

@behdad behdad commented May 1, 2023

Fixes #3097

One test needs updated expectations.

@behdad
Copy link
Member Author

behdad commented May 1, 2023

This basically undoes https://github.com/fonttools/fonttools/pull/2867/files and adds an option for it.

@behdad
Copy link
Member Author

behdad commented May 1, 2023

@punchcutter Can you please test this?

anthrotype
anthrotype approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see earlier comment about unused processLast parameter

@behdad
Copy link
Member Author

behdad commented May 2, 2023

LGTM, but see earlier comment about unused processLast parameter

PTAL.

@behdad behdad merged commit 6a13bdc into main May 2, 2023
@behdad behdad deleted the featureVars-processLast branch May 2, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature variations lookup order only rvrn should be first
2 participants
@behdad @anthrotype