Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VARC] Variable Composites table #3395

Merged
merged 114 commits into from
May 24, 2024
Merged

[VARC] Variable Composites table #3395

merged 114 commits into from
May 24, 2024

Conversation

behdad
Copy link
Member

@behdad behdad commented Dec 14, 2023

@behdad behdad marked this pull request as draft December 14, 2023 23:02
@behdad behdad force-pushed the varc-table branch 5 times, most recently from fb660e6 to ca824db Compare December 15, 2023 01:35
@behdad behdad mentioned this pull request Dec 15, 2023
Open
@behdad
Copy link
Member Author

behdad commented Dec 16, 2023 •
edited
Loading

This is mostly steady now. I'll go ahead and write a spec for it.

What is left to do is:

  • Rip out the glyf1 VarComposite glyphs,
  • Hook VARC up in ttGlyphSet so we can draw.

@behdad
Copy link
Member Author

behdad commented Dec 16, 2023

I should also somehow figure out how to do the VARC glyph loading lazy.

@behdad
Copy link
Member Author

behdad commented Dec 16, 2023 •
edited
Loading

TODO:

  • Make VARC table lazy-load glyphs.
  • Subsetter
  • Instancer
  • scaleUpem
  • tests

@behdad
Copy link
Member Author

behdad commented Dec 17, 2023

I can use some directions here. The multiVarStore and varStore share some similar code. Should I try to subclass them from a common class?

It will be more pronounced when adding subsetting to multiVarStore.

@behdad
Copy link
Member Author

behdad commented Dec 17, 2023

I can use some directions here. The multiVarStore and varStore share some similar code. Should I try to subclass them from a common class?

It will be more pronounced when adding subsetting to multiVarStore.

I managed to share some code by monkey-patching for now.

@behdad behdad marked this pull request as ready for review December 18, 2023 01:22
@behdad behdad force-pushed the varc-table branch 2 times, most recently from 87dc659 to c8a8b47 Compare December 18, 2023 01:40
@behdad
Copy link
Member Author

behdad commented Dec 18, 2023

This is ready for review. Thanks in advance @anthrotype @justvanrossum

@behdad
Copy link
Member Author

behdad commented Dec 18, 2023

This is ready for review. Thanks in advance @anthrotype @justvanrossum

It's terse but here's something of a spec for this:
https://github.com/harfbuzz/boring-expansion-spec/blob/main/varc.md

@behdad
Copy link
Member Author

behdad commented Dec 18, 2023

I probably should move some of the new code from otTables to a side module.

@behdad behdad force-pushed the varc-table branch 8 times, most recently from 8e75d94 to 2e057ba Compare December 20, 2023 18:50
behdad and others added 19 commits May 22, 2024 18:46
@behdad
[transform] Remove redundant methods
b3a0a21
@behdad
[lazyTools] Simplify based on review feedback
e3ba7a7
@behdad
[VarComponent] Nicer XML output
5ad4045 
#3395 (comment)
@behdad
[VARC] Load axisValues as float
037bbe1 
#3395 (comment)
@behdad
[VARC] Compute flags from XML transform components
5b2df6b
@behdad
[VARC] Minor, match spec better
7d6df04 
No functional change.
@behdad
[VARC] Adjust XML output based on review feedback
40584ad
@behdad
[VARC] Deepcopy the component
1acc80e 
Since we modify comp.transform.
@behdad
Fix otConverters lazy reader
3bada5d
@behdad
Newer black
a1641d9
@behdad
[CFF2IndexOf] Fix data_base
88828e0 
From the spec:
"Offsets in the offset array are relative to the byte
that precedes the object data."
@behdad
[varc] Skip reserved records
c155632
@behdad
[varc] Add ConditionSets
74f870f
@behdad
[varc] Conditionals tested!
d53c08a
@behdad
[varc] Add a conditional VarComponent test
9cb73da
@behdad
[varc] Use Condition instead of ConditionSet
973dc5c 
With more Condition formats.

harfbuzz/boring-expansion-spec@df7dcc4
harfbuzz/boring-expansion-spec#147
@justvanrossum @behdad
Don't emit addVarComponent() if the component references the parent g…
77add05 
…lyph (special case)
@behdad
[Condition] Implement ConditionValue
973072b 
Shift other Condition format numbers.

Implements
https://github.com/adobe-type-tools/opentype-spec-drafts/blob/main/condvalue_spec.md
@behdad
[varc] Use multiVarStore instead of GDEF varStore
753197e 
That's what we agreed upon.
@behdad
Copy link
Member Author

behdad commented May 24, 2024

I suggest landing this, as it's on the standardization pipeline now and settled.

@anthrotype
Copy link
Member

Sgtm

@behdad behdad merged commit db60a24 into main May 24, 2024
11 checks passed
@behdad behdad deleted the varc-table branch May 24, 2024 15:09
@justvanrossum
Copy link
Collaborator

A release would be the cherry on the cake.

@anthrotype
Copy link
Member

I can do that

@anthrotype
Copy link
Member

pushed tag https://github.com/fonttools/fonttools/releases/tag/4.52.0, wheels are building..

big release, perhaps worth a tweet?

@behdad
Copy link
Member Author

behdad commented May 24, 2024

pushed tag https://github.com/fonttools/fonttools/releases/tag/4.52.0, wheels are building..

big release, perhaps worth a tweet?

Yes please.

In HB we're thinking about calling it a 9.0.0

@anthrotype
Copy link
Member

in fonttools we bump major very infrequently, only when we break backward compatibility (e.g. when we swichted from py2.py3 to py3 only)

@m4rc1e m4rc1e mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

@justvanrossum justvanrossum Awaiting requested review from justvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@behdad @anthrotype @Lorp @justvanrossum