Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Glyphs-style "tuples" #6

Closed
simoncozens opened this issue Feb 9, 2021 · 2 comments · Fixed by #7
Closed

Support Glyphs-style "tuples" #6

simoncozens opened this issue Feb 9, 2021 · 2 comments · Fixed by #7

Comments

@simoncozens
Copy link
Contributor

Glyphs 3 plist files have "tuples" which appear on a single line even when other lines are separated/indented. The easiest way to support this would be to remove the if indent is not None... blocks from write_array_from_tuple. However, this may have Unintended Consequences.

@anthrotype
Copy link
Member

ugh. I really wish we can avoid adding quirks to this project, I'd like to keep it general purpose and not tied to Glyphs.app, even if it's the main target. Can we think about ways to inject some custom callbacks to format these maybe?

@anthrotype
Copy link
Member

on second thought, I guess it'd be fine if we add a new writer option, e.g. single_line_tuples=False, that optionally enable this. I see we already have two duplicate implementations for serializing list and tuple objects. Could you send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants