Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Unicode 14.0 #50

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Update to Unicode 14.0 #50

merged 1 commit into from
Dec 13, 2021

Conversation

khaledhosny
Copy link
Contributor

No description provided.

@khaledhosny
Copy link
Contributor Author

khaledhosny commented Dec 12, 2021 •
edited

It looks like the TravisCI setup is no longer operational.

@khaledhosny
Copy link
Contributor Author

It looks like the TravisCI setup is no longer operational.

Nor AppVeyor.

@anthrotype
Copy link
Member

Thanks Khaled, just checking -- how did you go about updating the unicodedata database? Since this is done so infrequently, I always forget how this was done the year before. Maybe we can/should add a note to the README as reminder for future selves.

@khaledhosny
Copy link
Contributor Author

I changed the Unicode version in the makeunicodedata.py script and ran it, it downloaded the data and regenerated the database. It complained about the CJK rangés not matching the ones in the script, so I updated them to match (no idea why the script does not do that itself). The change in the C files is copied from the cpython commit referenced in #44.

@anthrotype
Copy link
Member

@khaledhosny sounds good to me

@Harmon758 will this mark #44 as completed?

@anthrotype
Copy link
Member

anthrotype commented Dec 13, 2021 •
edited

@khaledhosny can you merge or rebase origin/master to run the GitHub Actions checks?

@anthrotype anthrotype merged commit bfbd3a3 into master Dec 13, 2021
@anthrotype anthrotype deleted the unicode-14 branch December 13, 2021 14:21
@SnoopJ SnoopJ mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khaledhosny @anthrotype