Skip to content

Commit

Permalink
Remove unused variable
Browse files Browse the repository at this point in the history
  • Loading branch information
kidhab committed Dec 21, 2021
1 parent d89a289 commit c35edea
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion docker-compose.yml
Expand Up @@ -26,7 +26,6 @@ services:
- REDIS_URL=redis://redis:6379
- SECRET_KEY_BASE=${FOODSOFT_SECRET_KEY_BASE}
- SHAREDLISTS_DATABASE_URL=mysql2://foodsoft:${FOODSOFT_DB_PASSWORD}@mariadb/sharedlists?encoding=utf8mb4
- MAILER_PREFIX=foodsoft+
- SMTP_DOMAIN=app.${DOMAIN}
- SMTP_ADDRESS
- SMTP_PORT
Expand Down

3 comments on commit c35edea

@wvengen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is not unused! See the smtp configuration, where foodsoft@mydomain is being forwarded to Foodsoft. Could you please put it back?
Foodsoft smtp is used, for example, for message replies.

@wvengen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, I cannot find it in the source code ... perhaps you are right ... need to look into it.

@wvengen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is "pending" to implement in Foodsoft: #2
Sorry for the noise, I'll document it there.

Please sign in to comment.