1037 migrate invoice attachments to active storage slow performance financial links #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yksflip
force-pushed
the
1037-migrate-invoice-attachments-to-active-storage-slow-performance-financial-links
branch
from
556f0f6
to
65c0fda
Compare
until now invoice attachments were stored in the database directly, this led to performance issues see #1037. This commit migrates the invoice attachments to use active storage. Additionally multiple attachments are now supported, a small preview is rendered and the delete flow was adapted.
yksflip
force-pushed
the
1037-migrate-invoice-attachments-to-active-storage-slow-performance-financial-links
branch
from
65c0fda
to
0bd6048
Compare
yksflip
changed the title
|
@yksflip Code looks good to me 👍 Anyhow, moving it to active storage is much cleaner 👍 |
|
thx for reviewing! Ah I see, yeah maybe I concluded a bit too quickly, that might have been enough to resolve the issue. |
yksflip
deleted the
1037-migrate-invoice-attachments-to-active-storage-slow-performance-financial-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now invoice attachments were stored in the database directly, this led to performance issues see #1037.
This PR migrates the invoice attachments to use active storage. Additionally multiple attachments are now supported, a small preview is rendered and the delete flow was adapted.
fixes #1037