cleanup show order and add search #253
Conversation
Conflicts: app/assets/stylesheets/bootstrap_and_overrides.css.less app/views/orders/_articles.html.haml app/views/orders/show.html.haml
Conflicts: app/helpers/orders_helper.rb
Conflicts: app/assets/stylesheets/bootstrap_and_overrides.css.less
|
This is the first of some larger user-interface changes. Since it's been 10 days now, I'd like to starting merging this. Let me know if this would or would not be an improvement for your coop. Or else, we'll find out in practice! |
|
Sorry I currently do not find the time to check it out. As far as I can see, nice changes. Have you made sure that the search input breaks nicely to the next line on smaller screens? |
|
|
||
| respond_to do |format| | ||
| @partial = case @view |
There was a problem hiding this comment.
Can this affect the rendering of the PDF now? The PDF is crucial for our workflow. If nothing has changed, it is fine.
There was a problem hiding this comment.
I'll move that to outside respond_to - don't know how it ended up there :o This does not change the PDF (@partial is used in html and js now).
|
Better would be the bottom in the gray box. But I'd like it to float, and consider this sufficient for now. |
|
Ah, that is fine. I have seen things like this being inaccessible on small screens due to bad clearing. Thanks for the screenshot! |
cleanup show order and add search
An attempt to make the show order screen a bit cleaner. Search works in default, groups and articles view (listjs).
p.s. Multiple
tfoots in in onetableare not allowed, so I moved these intermediate headings into the body, which had a nice side effect that listjs search showed the wholetbodywhen a row matched - exactly what I wanted.