Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure upfront tasks #331

Merged
merged 2 commits into from
Dec 6, 2014
Merged

Configure upfront tasks #331

merged 2 commits into from
Dec 6, 2014

Conversation

wvengen
Copy link
Member

@wvengen wvengen commented Nov 23, 2014

Solution for #324.

As I've hardly touched tasks before, it would be great of this could be reviewed by someone who used it.

@wvengen wvengen modified the milestone: 4.3 Nov 23, 2014
@wvengen
Copy link
Member Author

wvengen commented Dec 2, 2014

@robwa would you like to take a look?

@robwa
Copy link

robwa commented Dec 3, 2014

I've read the code and it looks good to me. I'm not able to test it at the moment though. But I'm sure you've done that.

@wvengen
Copy link
Member Author

wvengen commented Dec 6, 2014

Thanks. And indeed I've tested it :)

wvengen added a commit that referenced this pull request Dec 6, 2014
@wvengen wvengen merged commit cee2ac8 into master Dec 6, 2014
@wvengen wvengen removed the s:accepted label Dec 6, 2014
@wvengen wvengen deleted the feature/configure-upfront-tasks branch December 6, 2014 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants