Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit address from user profile #332

Merged
merged 2 commits into from
Dec 23, 2014
Merged

Conversation

wvengen
Copy link
Member

@wvengen wvengen commented Dec 10, 2014

Also makes members editing their profile a bit safer.

Any objections to members editing their ordergroup's address?

image

@wvengen wvengen added this to the 4.3 milestone Dec 10, 2014
@wvengen
Copy link
Member Author

wvengen commented Dec 15, 2014

@bennibu any objections to members editing their ordergroup's address?

@bennibu
Copy link
Contributor

bennibu commented Dec 16, 2014

@wvengen No, as long as we don't use this email as a sender/from Address in our mailers, this shouldn't be problem, I guess.

@wvengen
Copy link
Member Author

wvengen commented Dec 16, 2014

@bennibu Ehrm, I mean the physical address (email address is already editable) :) Right now this is not editable at all by members.

@bennibu
Copy link
Contributor

bennibu commented Dec 16, 2014

@wvengen ups, address, email address. It's always confusing. I don't see any problemes too, but as I can see from your screenshot, I would change the input label to something like Ordergroups's address. To make it more clear, what the user is actual editing.

@wvengen
Copy link
Member Author

wvengen commented Dec 16, 2014

@bennibu Thanks! To keep the form a bit easier to understand, a popup on the field?
shot
And perhaps only show the popup when there's more than one member in the ordergroup.

wvengen added a commit that referenced this pull request Dec 23, 2014
Allow to edit address from user profile
@wvengen wvengen merged commit 1c0db43 into master Dec 23, 2014
@wvengen wvengen deleted the feature/edit-address branch December 23, 2014 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants