increase test coverage #966
Conversation
There was a problem hiding this comment.
many thanks for the additional test. i think there are only a few stylistic issues. i know that we don't have a exact style guide and the current style is no consistent, but it would be great to use the ruby style guide where possible or stay at least consistent with the style of a file
spec/integration/supplier_spec.rb
Outdated
| visit suppliers_path | ||
| click_link I18n.t('ui.edit') | ||
| fill_in I18n.t('activerecord.attributes.supplier.name'), with: new_name | ||
| click_button 'Update Supplier' |
There was a problem hiding this comment.
coud not find the right i18n key ... find('input[type="submit"]').click should be okay too
|
thanks for your comments! |
yksflip
force-pushed
the
8_increase_test_coverage
branch
2 times, most recently
from
893021c
to
ad03caf
Compare
|
mh so rubocop want's but if i do so the |
add it to the could you please make your commit message a bit more clean and add what test (or at least in which area) are added in the commit. also please be consistent with the |
yksflip
force-pushed
the
8_increase_test_coverage
branch
from
ad03caf
to
44c7f33
Compare
|
thanks for your hints! I hope i covered them all now :) |
There was a problem hiding this comment.
super thanks for all the changes, could you make one small additional change for rubocop?
and sorry for not being more clear in the first step about the commit message: it would be great if the first line of the commit message would contain more information. I expect additional PRs about the test coverage in the near future and it would be great if they are at least a little bit distinguishable there 😉
This commit adds new tests for a better coverage. integration/ * home * supplier models/ * article * delivery * group_order_article * supplier also adds a new factory for delivery Co-authored-by: viehlieb <pf@pragma-shift.net> Co-authored-by: Tobias Kneuker <tk@pragma-shift.net>
yksflip
force-pushed
the
8_increase_test_coverage
branch
from
44c7f33
to
9fa58ff
Compare
|
ping :) |
this pr adds more integration and model tests to increase the test coverage.