Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot request package info for GraalVM CE with distribution name "Graal VM CE XX" #51

Closed
repolevedavaj opened this issue Dec 30, 2021 · 11 comments

Comments

@repolevedavaj
Copy link

If I try to request the package info for a specific GraalVM distribution with "Graal VM CE XX" as distribution name, I get a 400 status. If I use "GraalVM CE XX" as name, it works. According to https://api.foojay.io/disco/v2.0/distributions?include_versions=false, "Graal VM CE XX" is the official name and "GraalVM CE XX" just a synonym.

@HanSolo
Copy link
Collaborator

HanSolo commented Dec 30, 2021

The api_parameter in the response from https://api.foojay.io/disco/v2.0/distributions?include_versions=false is the value that should be used for the query

@repolevedavaj
Copy link
Author

Ah I see. Thanks for the quick feedback!

@sschuberth
Copy link

sschuberth commented Nov 24, 2022

Hmm, so while graalvm_ce11 is listed as an api_parameter, https://api.foojay.io/disco/v3.0/packages?distro=graalvm_ce11 says "No package(s) found". Is this expected @HanSolo? Because for some other distro like https://api.foojay.io/disco/v3.0/packages?distro=oracle_open_jdk it seems to work.

@HanSolo
Copy link
Collaborator

HanSolo commented Nov 24, 2022

Hmm...that's not correct, thx for the heads up, will take a look at it 👍🏻

@jbartok
Copy link

jbartok commented Nov 24, 2022

For my own clarification: is the right/recommended way of setting the distro param for packages using the api_parameter or the name of distributions?

@sschuberth
Copy link

The api_parameter should be used, see above.

@HanSolo
Copy link
Collaborator

HanSolo commented Nov 24, 2022

Already found the issue, it is related to the introduction of graalvm early access builds, will fix it asap and will close this issue as soon as it will be working as expected and be available in production.

@sschuberth
Copy link

will close this issue as soon as it will be working as expected and be available in production.

Thanks! However, then you should probably reopen this issue first 😁

@HanSolo HanSolo reopened this Nov 24, 2022
@HanSolo
Copy link
Collaborator

HanSolo commented Nov 24, 2022

Released the latest version to production and now it should work again as expected...could you please give it a try?

@sschuberth
Copy link

Looking good to me now, thanks a lot for the fast fix @HanSolo!

@HanSolo
Copy link
Collaborator

HanSolo commented Nov 24, 2022

Great, thx again for the report and testing 👍🏻😁

@HanSolo HanSolo closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants