This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Update unittests #1784
Merged
Update unittests #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@queengooborg sorry I neglected this. Can you rebase? |
|
|
foolip
approved these changes
Mar 28, 2022
| @@ -249,6 +249,11 @@ describe('/tests/', () => { | |||
| assert.equal(res.status, 200); | |||
| }); | |||
|
|
|||
| it('get all tests, ignore CSS', async () => { | |||
| const res = await agent.get('/tests/?ignore=css'); | |||
| assert.equal(res.status, 200); | |||
There was a problem hiding this comment.
Should something be asserted here that's different from the previous step? As it is, this test would pass even if the ignore parameter is unused.
There was a problem hiding this comment.
We should probably also check to make sure we're loading the correct tests as well in the previous two steps. I'm not sure how to do it at this time though, so I've added some TODO comments to remind us later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the unittests to add more coverage, as well as properly ignore blocks of code that are too challenging/impossible/not worthwhile to test.