This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fix find-missing-results #1826
Merged
Fix find-missing-results #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
suggested changes
Feb 21, 2022
find-missing-results.js
Outdated
| @@ -45,12 +45,10 @@ const generateReportMap = (allResults) => { | |||
| if (!allResults) { | |||
| if (browserKey == 'ie') { | |||
| // Ignore super old IE releases | |||
| result[browserKey] = result[browserKey].filter((v) => v >= '6'); | |||
| result[browserKey] = result[browserKey].filter((v) => v >= 6); | |||
There was a problem hiding this comment.
Can you use compareVersions here so that the string→number conversion isn't implicit?
foolip
reviewed
Feb 22, 2022
find-missing-results.js
Outdated
| @@ -45,11 +45,13 @@ const generateReportMap = (allResults) => { | |||
| if (!allResults) { | |||
| if (browserKey == 'ie') { | |||
| // Ignore super old IE releases | |||
| result[browserKey] = result[browserKey].filter((v) => v >= '6'); | |||
| result[browserKey] = result[browserKey].filter((v) => | |||
| compareVersions.compare(v, '6', '>') | |||
There was a problem hiding this comment.
Did you intend to change >= to >?
foolip
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the find-missing-results script. Apparently, when performing
'15' > '4', the strings are not converted to numbers during comparison, but rather compared lexicographically. This PR fixes that by replacing one of the sides of the comparison with an integer, so that IE 10 and 11 are included in the list, as well as Safari 10 or higher.Additionally, this removes the clause to exclude Safari 6.1, since BCD no longer has 6.1 in its data.