Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Fix api.CSSKeyframesRule, which is currently invalid JS #1960

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

gsnedders
Copy link
Contributor

This contains a new line within a JS string, which is syntactically invalid, and results in every browser giving null for this test.

This contains a new line within a JS string, which is syntactically invalid, and
results in every browser giving null for this test.
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up!

@queengooborg queengooborg merged commit 5796586 into foolip:main Apr 26, 2022
@gsnedders gsnedders deleted the fix-keyframes-rule branch April 27, 2022 00:05
@foolip
Copy link
Owner

foolip commented May 18, 2022

@queengooborg can you check if there are more cases like this introduced at the same time?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants