feat: add better naming of category and audit scores

foomo · Dec 5, 2018 · 3875229 · 3875229
1 parent be07af5
commit 3875229
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/collector/collector.go b/collector/collector.go
@@ -119,9 +119,10 @@ func collectLighthouseResults(prefix string, lhr *pagespeedonline.LighthouseResu
 		}
 
 		ch <- prometheus.MustNewConstMetric(
-			prometheus.NewDesc(fqname(prefix, k, "score"), v.Description, nil, constLabels),
+			prometheus.NewDesc(fqname(prefix, "category_score"), v.Description, []string{"category"}, constLabels),
 			prometheus.GaugeValue,
-			score)
+			score,
+			k)
 	}
 
 	for k, v := range lhr.Audits {
@@ -143,9 +144,10 @@ func collectLighthouseResults(prefix string, lhr *pagespeedonline.LighthouseResu
 		}
 
 		ch <- prometheus.MustNewConstMetric(
-			prometheus.NewDesc(fqname(prefix, "audit", k, "score"), v.Description, nil, constLabels),
+			prometheus.NewDesc(fqname(prefix, "audit_score"), "Lighthouse audit scores", []string{"audit"}, constLabels),
 			prometheus.GaugeValue,
-			score)
+			score,
+			k)
 	}
 }