Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new timing metrics #28

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add new timing metrics #28

merged 1 commit into from
Aug 12, 2020

Conversation

mintyfloss
Copy link

Add new timing metrics

This addresses #24.

  • bootup-time
  • largest-contentful-paint
  • mainthread-work-breakdown
  • cumulative-layout-shift
  • total-blocking-time
  • server-response-time
  • max-potential-fid
  • estimated-input-latency

There is a regex added in this PR to we can parse displayValue that looks like "Root document took 10 ms". It's too bad that we aren't able to access the numericValue and numericUnit so we don't have to parse displayValue.

- bootup-time
- largest-contentful-paint
- mainthread-work-breakdown
- cumulative-layout-shift
- total-blocking-time
- server-response-time
- max-potential-fid
- estimated-input-latency
Copy link
Contributor

@smartinov smartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@smartinov smartinov merged commit 018ab8a into foomo:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants